intel: Factor region updates out of intel_update_wrapper
authorChad Versace <chad@chad-versace.us>
Wed, 22 Jun 2011 23:08:49 +0000 (16:08 -0700)
committerChad Versace <chad@chad-versace.us>
Fri, 24 Jun 2011 21:47:20 +0000 (14:47 -0700)
... and into new function intel_update_tex_wrapper_regions.

This prevents code duplication in the next commit.

Also add a note explaining that the hiz region is broken for mipmapped
depth textures.

Signed-off-by: Chad Versace <chad@chad-versace.us>
src/mesa/drivers/dri/intel/intel_fbo.c

index b431f530826ab299f8ab6d18613f27b12baa5e51..fcbe451f2e6f4e92b2a9bcc82ae27cf54b369140 100644 (file)
@@ -497,6 +497,10 @@ intel_framebuffer_renderbuffer(struct gl_context * ctx,
    intel_draw_buffer(ctx, fb);
 }
 
+static bool
+intel_update_tex_wrapper_regions(struct intel_context *intel,
+                                struct intel_renderbuffer *irb,
+                                struct intel_texture_image *intel_image);
 
 static GLboolean
 intel_update_wrapper(struct gl_context *ctx, struct intel_renderbuffer *irb, 
@@ -523,6 +527,20 @@ intel_update_wrapper(struct gl_context *ctx, struct intel_renderbuffer *irb,
    irb->Base.Delete = intel_delete_renderbuffer;
    irb->Base.AllocStorage = intel_nop_alloc_storage;
 
+   return intel_update_tex_wrapper_regions(intel, irb, intel_image);
+}
+
+/**
+ * FIXME: The handling of the hiz region is broken for mipmapped depth textures
+ * FIXME: because intel_finalize_mipmap_tree is unaware of it.
+ */
+static bool
+intel_update_tex_wrapper_regions(struct intel_context *intel,
+                                struct intel_renderbuffer *irb,
+                                struct intel_texture_image *intel_image)
+{
+   struct gl_texture_image *texImage = &intel_image->base;
+
    /* Point the renderbuffer's region to the texture's region. */
    if (irb->region != intel_image->mt->region) {
       intel_region_release(&irb->region);