r300g: winsys fix tiling change flushes.
authorDave Airlie <airlied@redhat.com>
Sat, 20 Mar 2010 20:34:11 +0000 (06:34 +1000)
committerDave Airlie <airlied@redhat.com>
Sat, 20 Mar 2010 20:56:49 +0000 (06:56 +1000)
If we change the tiling on a buffer we need to flush it, the old
radeon_buffer.c code had this but it crossed streams when I ported to
radeon_drm_buffer.c and I missed it. Should fix some piglit regressions.

Signed-off-by: Dave Airlie <airlied@redhat.com>
src/gallium/winsys/drm/radeon/core/radeon_drm_buffer.c

index cc56a2bb8fd65c30ef89f58aba59a721d362c797..73472aabc5e30e5f6cb691f5519f9551ffc1b17e 100644 (file)
@@ -306,13 +306,21 @@ boolean radeon_drm_bufmgr_get_handle(struct pb_buffer *_buf,
 void radeon_drm_bufmgr_set_tiling(struct pb_buffer *_buf, boolean microtiled, boolean macrotiled, uint32_t pitch)
 {
     struct radeon_drm_buffer *buf = get_drm_buffer(_buf);
-    uint32_t flags = 0;
-
+    uint32_t flags = 0, old_flags, old_pitch;
     if (microtiled)
        flags |= RADEON_BO_FLAGS_MICRO_TILE;
     if (macrotiled)
        flags |= RADEON_BO_FLAGS_MACRO_TILE;
 
+    radeon_bo_get_tiling(buf->bo, &old_flags, &old_pitch);
+
+    if (flags != old_flags || pitch != old_pitch) {
+        /* Tiling determines how DRM treats the buffer data.
+         * We must flush CS when changing it if the buffer is referenced. */
+        if (radeon_bo_is_referenced_by_cs(buf->bo,  buf->mgr->rws->cs)) {
+           buf->mgr->rws->flush_cb(buf->mgr->rws->flush_data);
+        }
+    }
     radeon_bo_set_tiling(buf->bo, flags, pitch);
 
 }