v3d: Actually put the "%s" in the snprintf.
authorEric Anholt <eric@anholt.net>
Wed, 1 Aug 2018 18:25:58 +0000 (11:25 -0700)
committerEric Anholt <eric@anholt.net>
Wed, 1 Aug 2018 18:39:19 +0000 (11:39 -0700)
I missed an important part when porting the change over, fixing my
compiler warning but breaking -Werror=format-security.

Fixes: e6ff5ac4468e ("v3d: use snprintf(..., "%s", ...) instead of strncpy")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107443

src/broadcom/cle/v3d_decoder.c

index 4496388e319ec86d2f66b3639ae1b0c5dbd51a4a..373a1d996442e1bf52b642912e19e94f743d60eb 100644 (file)
@@ -834,7 +834,7 @@ iter_advance_field(struct v3d_field_iterator *iter)
 
         iter->field = iter->group->fields[iter->field_iter++];
         if (iter->field->name)
-                snprintf(iter->name, sizeof(iter->name), iter->field->name);
+                snprintf(iter->name, sizeof(iter->name), "%s", iter->field->name);
         else
                 memset(iter->name, 0, sizeof(iter->name));
         iter->offset = iter_group_offset_bits(iter, iter->group_iter) / 8 +