2011-06-15 Hui Zhu <teawater@gmail.com>

	* remote.c (remote_trace_set_readonly_regions): Add a check for
	target_buf_size.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 982eafc8fce5e5416f1f8b4b4178743eafa88b43..b40d0a6d136258983d409ba3cc341c73ad5704a3 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2011-06-15  Hui Zhu  <teawater@gmail.com>
+
+       * remote.c (remote_trace_set_readonly_regions): Add a check for
+       target_buf_size.
+
 2011-06-14  Tom Tromey  <tromey@redhat.com>
 
        * coffread.c (coffread_objfile): Rename from current_objfile.

diff --git a/gdb/remote.c b/gdb/remote.c
index b60a89c6b20d425cb0a924476bd6273c96bc921d..e30798617954a2f14cb74d079630a1ae2c886dc2 100644 (file)
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -9977,6 +9977,7 @@ remote_trace_set_readonly_regions (void)
   bfd_size_type size;
   bfd_vma vma;
   int anysecs = 0;
+  int offset = 0;
 
   if (!exec_bfd)
     return;                    /* No information to give.  */
@@ -9985,6 +9986,7 @@ remote_trace_set_readonly_regions (void)
   for (s = exec_bfd->sections; s; s = s->next)
     {
       char tmp1[40], tmp2[40];
+      int sec_length;
 
       if ((s->flags & SEC_LOAD) == 0 ||
       /*  (s->flags & SEC_CODE) == 0 || */
@@ -9996,8 +9998,15 @@ remote_trace_set_readonly_regions (void)
       size = bfd_get_section_size (s);
       sprintf_vma (tmp1, vma);
       sprintf_vma (tmp2, vma + size);
-      sprintf (target_buf + strlen (target_buf), 
-              ":%s,%s", tmp1, tmp2);
+      sec_length = 1 + strlen (tmp1) + 1 + strlen (tmp2);
+      if (offset + sec_length + 1 > target_buf_size)
+       {
+         warning (_("\
+Too many sections for read-only sections definition packet."));
+         break;
+       }
+      sprintf (target_buf + offset, ":%s,%s", tmp1, tmp2);
+      offset += sec_length;
     }
   if (anysecs)
     {