ARM process record: median instructions

This patch is to support some ARM median instructions in process
record.  With this patch applied, these fails are fixed:

 -FAIL: gdb.reverse/break-precsave.exp: run to end of main
 -FAIL: gdb.reverse/break-precsave.exp: go to end of main forward
 -FAIL: gdb.reverse/break-precsave.exp: end of record log
 -FAIL: gdb.reverse/break-reverse.exp: continue to breakpoint: end
 -FAIL: gdb.reverse/break-reverse.exp: end of record log
 -FAIL: gdb.reverse/until-precsave.exp: run to end of main
 -FAIL: gdb.reverse/until-precsave.exp: advance to marker2
 -FAIL: gdb.reverse/until-precsave.exp: until func, not called by current frame
 -FAIL: gdb.reverse/until-precsave.exp: reverse-advance to marker2
 -FAIL: gdb.reverse/until-precsave.exp: reverse-finish from marker2
 -FAIL: gdb.reverse/until-precsave.exp: reverse-advance to final return of factorial
 -FAIL: gdb.reverse/until-precsave.exp: reverse-until to entry of factorial
 -FAIL: gdb.reverse/until-reverse.exp: advance to marker2
 -FAIL: gdb.reverse/until-reverse.exp: until func, not called by current frame
 -FAIL: gdb.reverse/until-reverse.exp: reverse-advance to marker2
 -FAIL: gdb.reverse/until-reverse.exp: reverse-finish from marker2
 -FAIL: gdb.reverse/until-reverse.exp: reverse-advance to final return of factorial
 -FAIL: gdb.reverse/until-reverse.exp: reverse-until to entry of factorial

gdb:

2016-03-21  Yao Qi  <yao.qi@linaro.org>

	* arm-tdep.c (arm_record_media): New.
	(arm_record_ld_st_reg_offset): Call arm_record_media.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 551d07057da1ab0a9235dc0babfb7fe7041652f5..cfb37166eff4b1071513c6b6dd7e3a2cfd2619dd 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2016-03-21  Yao Qi  <yao.qi@linaro.org>
+
+       * arm-tdep.c (arm_record_media): New.
+       (arm_record_ld_st_reg_offset): Call arm_record_media.
+
 2016-03-21  Yao Qi  <yao.qi@linaro.org>
 
        * arm-linux-tdep.c (arm_canonicalize_syscall): Canonicalize

diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
index 54a21ef61c39afb1f08e5e59c51b26649538c4c0..ad6983402cb42188924446209013ae1636895287 100644 (file)
--- a/gdb/arm-tdep.c
+++ b/gdb/arm-tdep.c
@@ -10288,6 +10288,88 @@ arm_record_data_proc_imm (insn_decode_record *arm_insn_r)
   return 0;
 }
 
+static int
+arm_record_media (insn_decode_record *arm_insn_r)
+{
+  uint32_t record_buf[8];
+
+  switch (bits (arm_insn_r->arm_insn, 22, 24))
+    {
+    case 0:
+      /* Parallel addition and subtraction, signed */
+    case 1:
+      /* Parallel addition and subtraction, unsigned */
+    case 2:
+    case 3:
+      /* Packing, unpacking, saturation and reversal */
+      {
+       int rd = bits (arm_insn_r->arm_insn, 12, 15);
+
+       record_buf[arm_insn_r->reg_rec_count++] = rd;
+      }
+      break;
+
+    case 4:
+    case 5:
+      /* Signed multiplies */
+      {
+       int rd = bits (arm_insn_r->arm_insn, 16, 19);
+       unsigned int op1 = bits (arm_insn_r->arm_insn, 20, 22);
+
+       record_buf[arm_insn_r->reg_rec_count++] = rd;
+       if (op1 == 0x0)
+         record_buf[arm_insn_r->reg_rec_count++] = ARM_PS_REGNUM;
+       else if (op1 == 0x4)
+         record_buf[arm_insn_r->reg_rec_count++]
+           = bits (arm_insn_r->arm_insn, 12, 15);
+      }
+      break;
+
+    case 6:
+      {
+       if (bit (arm_insn_r->arm_insn, 21)
+           && bits (arm_insn_r->arm_insn, 5, 6) == 0x2)
+         {
+           /* SBFX */
+           record_buf[arm_insn_r->reg_rec_count++]
+             = bits (arm_insn_r->arm_insn, 12, 15);
+         }
+       else if (bits (arm_insn_r->arm_insn, 20, 21) == 0x0
+                && bits (arm_insn_r->arm_insn, 5, 7) == 0x0)
+         {
+           /* USAD8 and USADA8 */
+           record_buf[arm_insn_r->reg_rec_count++]
+             = bits (arm_insn_r->arm_insn, 16, 19);
+         }
+      }
+      break;
+
+    case 7:
+      {
+       if (bits (arm_insn_r->arm_insn, 20, 21) == 0x3
+           && bits (arm_insn_r->arm_insn, 5, 7) == 0x7)
+         {
+           /* Permanently UNDEFINED */
+           return -1;
+         }
+       else
+         {
+           /* BFC, BFI and UBFX */
+           record_buf[arm_insn_r->reg_rec_count++]
+             = bits (arm_insn_r->arm_insn, 12, 15);
+         }
+      }
+      break;
+
+    default:
+      return -1;
+    }
+
+  REG_ALLOC (arm_insn_r->arm_regs, arm_insn_r->reg_rec_count, record_buf);
+
+  return 0;
+}
+
 /* Handle ARM mode instructions with opcode 010.  */
 
 static int
@@ -10394,6 +10476,9 @@ arm_record_ld_st_reg_offset (insn_decode_record *arm_insn_r)
   LONGEST s_word;
   ULONGEST u_regval[2];
 
+  if (bit (arm_insn_r->arm_insn, 4))
+    return arm_record_media (arm_insn_r);
+
   arm_insn_r->opcode = bits (arm_insn_r->arm_insn, 21, 24);
   arm_insn_r->decode = bits (arm_insn_r->arm_insn, 4, 7);