[gdb/testsuite] Compile index-cache.c with -Wl,--build-id

When testing gdb.base/index-cache.exp using a gcc build without
--enable-linker-build-id we get:
...
FAIL: gdb.base/index-cache.exp: \
  test_cache_enabled_miss: at least one file was created
FAIL: gdb.base/index-cache.exp: \
  test_cache_enabled_miss: couldn't get executable build id
FAIL: gdb.base/index-cache.exp: \
test_cache_enabled_hit: check index-cache stats
...

With "set debug index-cache on" we find:
...
(gdb) file index-cache
Reading symbols from index-cache...
index cache: objfile index-cache has no build id
...

The problem is that a build-id is required for the index-cache functionality.

Fix this by compiling index-cache.c with -Wl,--build-id.

Tested on x86_64-linux.

gdb/testsuite/ChangeLog:

2019-06-21  Tom de Vries  <tdevries@suse.de>

	* gdb.base/index-cache.exp: Add additional_flags=-Wl,--build-id.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index d4e7d8b6707a83024d308b88ea2ee28b0879cc21..8cd3c5119418a689f2616826048c3cf75ec8c2f6 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2019-06-21  Tom de Vries  <tdevries@suse.de>
+
+       * gdb.base/index-cache.exp: Add additional_flags=-Wl,--build-id.
+
 2019-06-21  Tom de Vries  <tdevries@suse.de>
 
        PR testsuite/24518

diff --git a/gdb/testsuite/gdb.base/index-cache.exp b/gdb/testsuite/gdb.base/index-cache.exp
index 075dffe3f5eaf99f50875fc22abfcb4a66f6ef5c..6f1488e03718b20a3de79d95a68057aaa0d54744 100644 (file)
--- a/gdb/testsuite/gdb.base/index-cache.exp
+++ b/gdb/testsuite/gdb.base/index-cache.exp
@@ -18,7 +18,8 @@
 
 standard_testfile
 
-if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } {
+if { [prepare_for_testing "failed to prepare" $testfile $srcfile \
+         {additional_flags=-Wl,--build-id}] } {
     return
 }