r600g: check NULL return from u_upload_alloc
authorJulien Isorce <jisorce@oblong.com>
Thu, 23 Mar 2017 13:34:07 +0000 (13:34 +0000)
committerJulien Isorce <jisorce@oblong.com>
Tue, 28 Mar 2017 16:54:15 +0000 (17:54 +0100)
Like done in si_state_draw.c::si_draw_vbo

u_upload_alloc can fail, i.e. set output param *ptr to NULL, for 2 reasons:
alloc fails or map fails. For both there is already a fprintf/stderr in
radeon_create_bo and radeon_bo_do_map.

In src/gallium/drivers/ it is a common usage to just avoid to crash by doing
a silent check. But defer fprintf where the error comes from, libdrm calls.

Signed-off-by: Julien Isorce <jisorce@oblong.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
src/gallium/drivers/r600/r600_state_common.c

index 6f8279fb5e6b0905691bb49a5a4eb71854044a43..cedeb74e2d7d9a73ae9a8f26a30f46e832650d91 100644 (file)
@@ -1746,6 +1746,10 @@ static void r600_draw_vbo(struct pipe_context *ctx, const struct pipe_draw_info
 
                        u_upload_alloc(ctx->stream_uploader, start, count * 2,
                                        256, &out_offset, &out_buffer, &ptr);
+                       if (unlikely(!ptr)) {
+                               pipe_resource_reference(&ib.buffer, NULL);
+                               return;
+                       }
 
                        util_shorten_ubyte_elts_to_userptr(
                                                &rctx->b.b, &ib, 0, 0, ib.offset + start, count, ptr);