Add asserts in target_fetch/store_registers

We are currently assuming that regcache->ptid is equal to inferior_ptid
when we call target_fetch/store_registers.  These asserts just validate
that assumption.  Also, since the following patches will change target
code to use regcache->ptid instead of inferior_ptid, asserting that they
are the same should ensure that our changes don't have any unintended
consequences.

gdb/ChangeLog:

	* target.c (target_fetch_registers, target_store_registers): Add
	assert.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 3e155a3e68ac4cb741e97a959504d01c8d36f294..f8cb9477e3af47abe9918a71dd8ad84edf9b8d8f 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2017-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
+
+       * target.c (target_fetch_registers, target_store_registers): Add
+       assert.
+
 2017-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 
        * regcache.h (regcache_get_ptid): New function.

diff --git a/gdb/target.c b/gdb/target.c
index 0ff8515d3b731ff5929e5c9c68a20d124c1ecd67..359bf0dec9ba9376bd2814500e64539543a439ae 100644 (file)
--- a/gdb/target.c
+++ b/gdb/target.c
@@ -3587,6 +3587,8 @@ debug_print_register (const char * func,
 void
 target_fetch_registers (struct regcache *regcache, int regno)
 {
+  gdb_assert (ptid_equal (regcache_get_ptid (regcache), inferior_ptid));
+
   current_target.to_fetch_registers (&current_target, regcache, regno);
   if (targetdebug)
     debug_print_register ("target_fetch_registers", regcache, regno);
@@ -3598,6 +3600,8 @@ target_store_registers (struct regcache *regcache, int regno)
   if (!may_write_registers)
     error (_("Writing to registers is not allowed (regno %d)"), regno);
 
+  gdb_assert (ptid_equal (regcache_get_ptid (regcache), inferior_ptid));
+
   current_target.to_store_registers (&current_target, regcache, regno);
   if (targetdebug)
     {