Remove string-related cleanup from c-exp.y

This removes a string-related cleanup from c-exp.y, by adding a new
member to c_parse_state to store the strings.

gdb/ChangeLog
2019-01-06  Tom Tromey  <tom@tromey.com>

	* c-exp.y (struct c_parse_state) <strings>: New member.
	(operator_stoken): Update.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 6ca534a0d24e94ad64fb54ca126e03bb86bb539b..57c758807536713af9f5da311f7e6cdeb18b09c4 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-01-06  Tom Tromey  <tom@tromey.com>
+
+       * c-exp.y (struct c_parse_state) <strings>: New member.
+       (operator_stoken): Update.
+
 2019-01-06  Tom Tromey  <tom@tromey.com>
 
        * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.

diff --git a/gdb/c-exp.y b/gdb/c-exp.y
index 54eb38935bdc30c90d49c7d9a2519396be23c12a..10e4ada5f043341f6403bc859d60ea192282b365 100644 (file)
--- a/gdb/c-exp.y
+++ b/gdb/c-exp.y
@@ -74,6 +74,9 @@ struct c_parse_state
      allocated during the parse.  */
   std::vector<std::unique_ptr<std::vector<struct type *>>> type_lists;
   std::vector<std::unique_ptr<struct type_stack>> type_stacks;
+
+  /* Storage for some strings allocated during the parse.  */
+  std::vector<gdb::unique_xmalloc_ptr<char>> strings;
 };
 
 /* This is set and cleared in c_parse.  */
@@ -1743,7 +1746,7 @@ operator_stoken (const char *op)
   st.ptr = buf;
 
   /* The toplevel (c_parse) will free the memory allocated here.  */
-  make_cleanup (free, buf);
+  cpstate->strings.emplace_back (buf);
   return st;
 };