Silence ARI warning about floatformat_to_double

This silences ARI at the one spot that is permitted to call
floatformat_to_double, and also removes the corresponding "fix" call
from gdb_ari.sh -- it was incorrect, and now is not needed.

gdb/ChangeLog
2019-12-13  Tom Tromey  <tromey@adacore.com>

	* contrib/ari/gdb_ari.sh: Remove "fix" call for
	floatformat_to_double.
	* target-float.c (host_float_ops<T>::from_target): Add ARI
	comment.

Change-Id: I778a17a04da417c113194004dd7de3b1df381266

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 44bb65ffccc3eb7f24c05bb6ee8986eb82d92e33..d107b6cea7fca35696fa2e16f759ccbe14e63a56 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2019-12-13  Tom Tromey  <tromey@adacore.com>
+
+       * contrib/ari/gdb_ari.sh: Remove "fix" call for
+       floatformat_to_double.
+       * target-float.c (host_float_ops<T>::from_target): Add ARI
+       comment.
+
 2019-12-13  Tom Tromey  <tromey@adacore.com>
 
        * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.

diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index 300ed761f13f43bc0e05e776ec1a0da38d106cb8..9a5b941d23f2d9a3fd8cb4204360365918240e59 100755 (executable)
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -810,7 +810,6 @@ get_frame_locals_address, or get_frame_args_address."
 BEGIN { doc["floatformat_to_double"] = "\
 Do not use floatformat_to_double() from libierty, \
 instead use floatformat_to_doublest()"
-    fix("floatformat_to_double", "gdb/doublest.c", 1)
     category["floatformat_to_double"] = ari_regression
 }
 /(^|[^_[:alnum:]])floatformat_to_double[[:space:]]*\(/ {

diff --git a/gdb/target-float.c b/gdb/target-float.c
index caa6943395016cb19e9dcef1a3bdb5375fc1d7bb..ddf20c89068ecf996e81f4808ff98ead3fe180ff 100644 (file)
--- a/gdb/target-float.c
+++ b/gdb/target-float.c
@@ -647,8 +647,8 @@ host_float_ops<T>::from_target (const struct floatformat *fmt,
     {
       double dto;
 
-      floatformat_to_double (fmt->split_half ? fmt->split_half : fmt,
-                            from, &dto);
+      floatformat_to_double    /* ARI: floatformat_to_double */
+       (fmt->split_half ? fmt->split_half : fmt, from, &dto);
       *to = (T) dto;
       return;
     }