Fixes a bug in the previous delat to tekhex.c which meant that valid tekhex files...

	* tekhex.c (getvalue): Fix thinko in test for correct extraction
	of value.
	(getsym): Return false if there was not enough data to extract the
	symbol.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 1bc66e419a74ed729e64a202b023059641cb7d64..70b138b2d053482ef36b2579eb91709b00362f3f 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,10 @@
+2015-01-09  Nick Clifton  <nickc@redhat.com>
+
+       * tekhex.c (getvalue): Fix thinko in test for correct extraction
+       of value.
+       (getsym): Return false if there was not enough data to extract the
+       symbol.
+
 2015-01-09  Anthony Green  <green@moxielogic.com>
 
        * elf32-moxie.c (ELF_MACHINE_ALT1): Define.

diff --git a/bfd/tekhex.c b/bfd/tekhex.c
index 9444117e5ffe83a4ec8e3dce83505ff7b893912d..94b47739f561675db231cb934f4b08e6c9ba9dcd 100644 (file)
--- a/bfd/tekhex.c
+++ b/bfd/tekhex.c
@@ -288,7 +288,7 @@ getvalue (char **srcp, bfd_vma *valuep, char * endp)
 
   *srcp = src;
   *valuep = value;
-  return len == 0;
+  return len == -1U;
 }
 
 static bfd_boolean
@@ -309,7 +309,7 @@ getsym (char *dstp, char **srcp, unsigned int *lenp, char * endp)
   dstp[i] = 0;
   *srcp = src + i;
   *lenp = len;
-  return TRUE;
+  return i == len;
 }
 
 static struct data_struct *