re PR tree-optimization/90626 (fold strcmp(a, b) == 0 to zero when one string length...

PR tree-optimization/90626

gcc/ChangeLog:
	* tree-ssa-strlen.c (strxcmp_unequal): Fix typos.

From-SVN: r272487

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 3f868bacad45f3a5abca5fe7ab28d3b2ef7de9f4..5b67ad0ede3070f9ac124f923c8756f92b7f6a40 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -11,6 +11,9 @@
 
 2019-06-19  Martin Sebor  <msebor@redhat.com>
 
+       PR tree-optimization/90626
+       * tree-ssa-strlen.c (strxcmp_unequal): Fix typos.
+
        PR tree-optimization/90626
        * tree-ssa-strlen.c (strxcmp_unequal): New function.
        (handle_builtin_string_cmp): Call it.

diff --git a/gcc/tree-ssa-strlen.c b/gcc/tree-ssa-strlen.c
index 80e7f9992d484fedb172a03663b7155ef313a382..74cd6c44874c48c741110ed8bad7f16764d74ece 100644 (file)
--- a/gcc/tree-ssa-strlen.c
+++ b/gcc/tree-ssa-strlen.c
@@ -2981,7 +2981,7 @@ strxcmp_unequal (int idx1, int idx2, unsigned HOST_WIDE_INT n)
   if (idx2 < 0)
     {
       len2 = ~idx2;
-      nulterm1 = true;
+      nulterm2 = true;
     }
   else if (strinfo *si = get_strinfo (idx2))
     {
@@ -3003,7 +3003,8 @@ strxcmp_unequal (int idx1, int idx2, unsigned HOST_WIDE_INT n)
   if (len2 > n)
     len2 = n;
 
-  if (len1 != len2 && (nulterm1 || nulterm2))
+  if ((len1 < len2 && nulterm1)
+      || (len2 < len1 && nulterm2))
     /* The string lengths are definitely unequal and the result can
        be folded to one (since it's used for comparison with zero).  */
     return true;