pan/bi: Assert out i16 related converts for now
authorAlyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Sat, 28 Mar 2020 00:11:07 +0000 (20:11 -0400)
committerMarge Bot <eric+marge@anholt.net>
Tue, 31 Mar 2020 01:12:26 +0000 (01:12 +0000)
Needs more investigation, and GLSL doesn't use it quite yet sadly.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4382>

src/panfrost/bifrost/bi_pack.c

index c53b40fe2b4e60673d3be32c64189cc810e88fad..f60efd9ad1955080ea41630f9ac793c9f8b89922 100644 (file)
@@ -621,6 +621,7 @@ bi_pack_fma_convert(bi_instruction *ins, struct bi_registers *regs)
 
         if (from_size == 16 && to_size == 16) {
                 /* f2i_i2f16 */
+                unreachable("i16 not yet implemented");
         } else if (from_size == 32 && to_size == 32) {
                 unsigned op = 0;
 
@@ -638,7 +639,7 @@ bi_pack_fma_convert(bi_instruction *ins, struct bi_registers *regs)
                         return bi_pack_fma_1src(ins, regs,
                                         BIFROST_FMA_FLOAT16_TO_32(from_y));
                 } else {
-                        /* int16_to_32 */
+                        unreachable("i16 not yet implemented");
                 }
         } else if (from_size == 32 && to_size == 16) {
                 if (from_base == nir_type_float) {
@@ -651,11 +652,11 @@ bi_pack_fma_convert(bi_instruction *ins, struct bi_registers *regs)
 
                         RETURN_PACKED(pack);
                 } else {
-                        /* XXX: No int32_to_int16? */
+                        unreachable("i16 not yet implemented");
                 }
         }
 
-        return BIFROST_FMA_NOP;
+        unreachable("Unknown convert");
 }
 
 static unsigned