vc4: Correct typo setting 'handled_qinst_cond'
authorRhys Kidd <rhyskidd@gmail.com>
Sat, 13 Feb 2016 18:21:15 +0000 (13:21 -0500)
committerEric Anholt <eric@anholt.net>
Tue, 16 Feb 2016 01:13:52 +0000 (17:13 -0800)
Variable was previously always set to true. Accordingly, the later
assert() served no active purpose.

Found with GCC warning and code inspection:

mesa/src/gallium/drivers/vc4/vc4_qpu_emit.c: In function'vc4_generate_code':
mesa/src/gallium/drivers/vc4/vc4_qpu_emit.c:315:22: warning: variable 'handled_qinst_cond' set but not used [-Wunused-but-set-variable]
                 bool handled_qinst_cond = true;
                      ^

Signed-off-by: Rhys Kidd <rhyskidd@gmail.com>
Signed-off-by: Eric Anholt <eric@anholt.net>
src/gallium/drivers/vc4/vc4_qpu_emit.c

index b06702afea27761604aee4fc4fa57f918dd3da22..450b97fc014f63d03f6a1c8a13835ce1ebaacb99 100644 (file)
@@ -312,7 +312,7 @@ vc4_generate_code(struct vc4_context *vc4, struct vc4_compile *c)
                         break;
                 }
 
-                bool handled_qinst_cond = true;
+                bool handled_qinst_cond = false;
 
                 switch (qinst->op) {
                 case QOP_RCP: