re PR libfortran/51119 (MATMUL slow for large matrices)

2017-02-26  Thomas Koenig  <tkoenig@gcc.gnu.org>

	PR fortran/51119
	* options.c (gfc_post_options): Set default limit for matmul
	inlining to 30.
	* invoke.texi: Document change.

2017-02-26  Thomas Koenig  <tkoenig@gcc.gnu.org>

	PR fortran/51119
	* gfortran.dg/inline_matmul_1.f90: Scan optimized dump instead
	of original.
	* gfortran.dg/inline_matmul_11.f90: Likewise.
	* gfortran.dg/inline_matmul_9.f90: Likewise.
	* gfortran.dg/matmul_13.f90: New test.
	* gfortran.dg/matmul_14.f90: New test.

From-SVN: r245745

diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog
index 6ee14745adfbb57fde3171ff2e6b29b202c9eabe..e3af1c5e9430dd05429203df72e6b466fb0866ba 100644 (file)
--- a/gcc/fortran/ChangeLog
+++ b/gcc/fortran/ChangeLog
@@ -1,3 +1,10 @@
+2017-02-26  Thomas Koenig  <tkoenig@gcc.gnu.org>
+
+       PR fortran/51119
+       * options.c (gfc_post_options): Set default limit for matmul
+       inlining to 30.
+       * invoke.texi: Document change.
+
 2017-02-25  Dominique d'Humieres  <dominiq@lps.ens.fr>
 
        PR fortran/79601

diff --git a/gcc/fortran/invoke.texi b/gcc/fortran/invoke.texi
index 2a89647f9f0c094ee202625729f238407f814bc3..636432fead8b8645490112cd58ff679f6c1f32b2 100644 (file)
--- a/gcc/fortran/invoke.texi
+++ b/gcc/fortran/invoke.texi
@@ -1629,9 +1629,8 @@ for matrices with size up to @var{n}. If the matrices involved are not
 square, the size comparison is performed using the geometric mean of
 the dimensions of the argument and result matrices.
 
-The default value for @var{n} is the value specified for
-@code{-fblas-matmul-limit} if this option is specified, or unlimitited
-otherwise.
+The default value for @var{n} is 30.  The @code{-fblas-matmul-limit}
+can be used to change this value.
 
 @item -frecursive
 @opindex @code{frecursive}

diff --git a/gcc/fortran/options.c b/gcc/fortran/options.c
index dc8df5b8ed3ddf8685a9aa2cf2aecd5d8325f4d3..1af76aa81ec440fbc4d045fbc7ec1e2f63f7f0f1 100644 (file)
--- a/gcc/fortran/options.c
+++ b/gcc/fortran/options.c
@@ -388,10 +388,16 @@ gfc_post_options (const char **pfilename)
   if (!flag_automatic)
     flag_max_stack_var_size = 0;
   
-  /* If we call BLAS directly, only inline up to the BLAS limit.  */
+  /* If the user did not specify an inline matmul limit, inline up to the BLAS
+     limit or up to 30 if no external BLAS is specified.  */
 
-  if (flag_external_blas && flag_inline_matmul_limit < 0)
-    flag_inline_matmul_limit = flag_blas_matmul_limit;
+  if (flag_inline_matmul_limit < 0)
+    {
+      if (flag_external_blas)
+       flag_inline_matmul_limit = flag_blas_matmul_limit;
+      else
+       flag_inline_matmul_limit = 30;
+    }
 
   /* Optimization implies front end optimization, unless the user
      specified it directly.  */

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index e2850e84f88bf48507b309f8d93056f6d10627a3..30198a6bfe3f7ba934022929a080164ad0fadd2b 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,13 @@
+2017-02-26  Thomas Koenig  <tkoenig@gcc.gnu.org>
+
+       PR fortran/51119
+       * gfortran.dg/inline_matmul_1.f90: Scan optimized dump instead
+       of original.
+       * gfortran.dg/inline_matmul_11.f90: Likewise.
+       * gfortran.dg/inline_matmul_9.f90: Likewise.
+       * gfortran.dg/matmul_13.f90: New test.
+       * gfortran.dg/matmul_14.f90: New test.
+
 2017-02-25  Jakub Jelinek  <jakub@redhat.com>
 
        PR middle-end/79396

diff --git a/gcc/testsuite/gfortran.dg/inline_matmul_1.f90 b/gcc/testsuite/gfortran.dg/inline_matmul_1.f90
index 266aad073d4e8429a5ea6e5648737594e15b9b2c..c3177d72361556fba3ebc104e9fa7164cd4dd8c2 100644 (file)
--- a/gcc/testsuite/gfortran.dg/inline_matmul_1.f90
+++ b/gcc/testsuite/gfortran.dg/inline_matmul_1.f90
@@ -1,5 +1,5 @@
 ! { dg-do  run }
-! { dg-options "-ffrontend-optimize -fdump-tree-original -Wrealloc-lhs" }
+! { dg-options "-ffrontend-optimize -fdump-tree-optimized -Wrealloc-lhs" }
 ! PR 37131 - check basic functionality of inlined matmul, making
 ! sure that the library is not called, with and without reallocation.
 
@@ -149,4 +149,4 @@ program main
 
 end program main
 
-! { dg-final { scan-tree-dump-times "_gfortran_matmul" 0 "original" } }
+! { dg-final { scan-tree-dump-times "_gfortran_matmul" 0 "optimized" } }

diff --git a/gcc/testsuite/gfortran.dg/inline_matmul_11.f90 b/gcc/testsuite/gfortran.dg/inline_matmul_11.f90
index 783c83c729ac068f851ff63ed8f2bbbce277423f..016d8d701cba13715fed11092135f7d3ddbef697 100644 (file)
--- a/gcc/testsuite/gfortran.dg/inline_matmul_11.f90
+++ b/gcc/testsuite/gfortran.dg/inline_matmul_11.f90
@@ -1,5 +1,5 @@
 ! { dg-do  run }
-! { dg-additional-options "-ffrontend-optimize -fdump-tree-original" }
+! { dg-additional-options "-ffrontend-optimize -fdump-tree-optimized" }
 ! PR fortran/66176 - inline conjg for matml.
 program main
   complex, dimension(3,2) :: a
@@ -29,4 +29,4 @@ program main
   c = matmul(conjg(a), b)
   if (any(conjg(c) /= res2)) call abort
 end program main
-! { dg-final { scan-tree-dump-times "_gfortran_matmul" 0 "original" } }
+! { dg-final { scan-tree-dump-times "_gfortran_matmul" 0 "optimized" } }

diff --git a/gcc/testsuite/gfortran.dg/inline_matmul_9.f90 b/gcc/testsuite/gfortran.dg/inline_matmul_9.f90
index 67b9fcad398a098c508e3692ab417a9ef13ed748..901cd96e24fee788477b6df409a8f9efddc6583b 100644 (file)
--- a/gcc/testsuite/gfortran.dg/inline_matmul_9.f90
+++ b/gcc/testsuite/gfortran.dg/inline_matmul_9.f90
@@ -1,5 +1,5 @@
 ! { dg-do  run }
-! { dg-options "-ffrontend-optimize -fdump-tree-original" }
+! { dg-options "-ffrontend-optimize -fdump-tree-optimized" }
 ! PR 66041 - this used to ICE with an incomplete fix for the PR.
 program main
   implicit none
@@ -21,4 +21,4 @@ program main
   if (any (c2-reshape([248., -749.],shape(c2)) /= 0.)) call abort
 end program main
 
-! { dg-final { scan-tree-dump-times "_gfortran_matmul" 0 "original" } }
+! { dg-final { scan-tree-dump-times "_gfortran_matmul" 0 "optimized" } }

diff --git a/gcc/testsuite/gfortran.dg/matmul_13.f90 b/gcc/testsuite/gfortran.dg/matmul_13.f90
new file mode 100644 (file)
index 0000000..3262d1a
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/matmul_13.f90
@@ -0,0 +1,12 @@
+! { dg-do compile }
+! { dg-options "-O3 -fdump-tree-optimized" }
+! Check that the default limit of 30 for inlining matmul applies.
+program main
+  integer, parameter :: n = 31
+  real, dimension(n,n) :: a, b, c
+  call random_number(a)
+  call random_number(b)
+  c = matmul(a,b)
+  print *,sum(c)
+end program main
+! { dg-final { scan-tree-dump-times "_gfortran_matmul_r4" 1 "optimized" } }

diff --git a/gcc/testsuite/gfortran.dg/matmul_14.f90 b/gcc/testsuite/gfortran.dg/matmul_14.f90
new file mode 100644 (file)
index 0000000..5c2b3f2
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/matmul_14.f90
@@ -0,0 +1,12 @@
+! { dg-do compile }
+! { dg-options "-O3 -fdump-tree-optimized" }
+! Check that the default limit of 30 for inlining matmul applies.
+program main
+  integer, parameter :: n = 30
+  real, dimension(n,n) :: a, b, c
+  call random_number(a)
+  call random_number(b)
+  c = matmul(a,b)
+  print *,sum(c)
+end program main
+! { dg-final { scan-tree-dump-times "_gfortran_matmul_r4" 0 "optimized" } }