Revise "ld testsuite use of notarget"

git commit 624940689a wrongly changed fill.d and fill16.d notarget
entries to xfail, so revert that change and instead replace notarget
with skip.  The two tests are complementary.

This patch also modifies the pr20022 test to use .data, avoiding
xfails on targets that complain about dynamic relocations in .text.
This shows a bug in metag which discards section _foo in pr2022.so.

	* testsuite/ld-elf/hash.d: Comment on mips xfail.
	* testsuite/ld-gc/pr20022b.s: Use .data not .text.
	* testsuite/ld-gc/pr20022.d: Remove xfails.
	* testsuite/ld-scripts/fill.d: Revert most of last patch, but use
	skip rather than notarget.
	* testsuite/ld-scripts/fill16.d: Likewise.

diff --git a/ld/ChangeLog b/ld/ChangeLog
index 01e9465a227e268ea1fd3c6c03dd953be9a2facd..f2c1103e741138519fa36e89b40477c49d5b4aa4 100644 (file)
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,12 @@
+2018-07-11  Alan Modra  <amodra@gmail.com>
+
+       * testsuite/ld-elf/hash.d: Comment on mips xfail.
+       * testsuite/ld-gc/pr20022b.s: Use .data not .text.
+       * testsuite/ld-gc/pr20022.d: Remove xfails.
+       * testsuite/ld-scripts/fill.d: Revert most of last patch, but use
+       skip rather than notarget.
+       * testsuite/ld-scripts/fill16.d: Likewise.
+
 2018-07-10  Maciej W. Rozycki  <macro@mips.com>
 
        * testsuite/ld-mips-elf/mips-elf.exp: Limit export class call

diff --git a/ld/testsuite/ld-elf/hash.d b/ld/testsuite/ld-elf/hash.d
index 593d48739b2eac06f857ad39d0a2b05e25d18646..fb079124e5bc04b65b97d89abda42779129941bc 100644 (file)
--- a/ld/testsuite/ld-elf/hash.d
+++ b/ld/testsuite/ld-elf/hash.d
@@ -3,6 +3,8 @@
 #ld: -shared --hash-style=gnu
 #target: *-*-linux* *-*-gnu* arm*-*-uclinuxfdpiceabi
 #xfail: mips*-*-*
+# GNU hash is not supported for MIPS targets due to psABI restrictions
+# on dynsym table ordering.
 
 #...
  +0x[0-9a-z]+ +\(GNU_HASH\) +0x[0-9a-z]+

diff --git a/ld/testsuite/ld-gc/pr20022.d b/ld/testsuite/ld-gc/pr20022.d
index 681c68c48bdbea7ea4f75e9f6a888f68ddfc126c..7623041c410fdc7714d7f928a4606e53891392e5 100644 (file)
--- a/ld/testsuite/ld-gc/pr20022.d
+++ b/ld/testsuite/ld-gc/pr20022.d
@@ -2,8 +2,6 @@
 #ld: --gc-sections -e _start tmpdir/pr20022.so
 #readelf: -SsW
 #target: *-*-linux* *-*-gnu* arm*-*-uclinuxfdpiceabi
-#xfail: frv-*-* metag-*-* mips*-*-*
-# Skip on targets without dynamic relocations in .text section.
 
 #...
   \[[ 0-9]+\] _foo[ \t]+PROGBITS[ \t]+[0-9a-f]+ +[0-9a-f]+ +[0-9a-f]+[ \t]+.*

diff --git a/ld/testsuite/ld-gc/pr20022b.s b/ld/testsuite/ld-gc/pr20022b.s
index 2306c59d7657a713f500ef10ca0782eb6611afc5..029956e891234c272165aa4afbf36280535d22bc 100644 (file)
--- a/ld/testsuite/ld-gc/pr20022b.s
+++ b/ld/testsuite/ld-gc/pr20022b.s
@@ -1,4 +1,4 @@
-       .text
+       .data
        .globl _start
 _start:
        .dc.a   __start__foo

diff --git a/ld/testsuite/ld-scripts/fill.d b/ld/testsuite/ld-scripts/fill.d
index 07dca0b6491af7734adbc1452d74e05129adad68..4a263497a8b115e95e0015852e91e8895a840554 100644 (file)
--- a/ld/testsuite/ld-scripts/fill.d
+++ b/ld/testsuite/ld-scripts/fill.d
@@ -3,13 +3,13 @@
 #source: fill_2.s
 #ld: -T fill.t
 #objdump: -s -j .text
-#xfail: alpha*-*-*ecoff ia64-*-* m32c-*-* mips*-*-freebsd* mips*-*-gnu*
-#xfail: mips*-*-irix* mips*-*-kfreebsd* mips*-*-linux* mips*-*-netbsd*
-#xfail: mips*-*-openbsd* mips*-*-sysv4* sh-*-pe sparc*-*-coff
-#xfail: tic30-*-coff tic4x-*-* tic54x-*-* tilegx*-*-* tilepro-*-*
-#xfail: x86_64-*-cygwin x86_64-*-mingw* x86_64-*-pe* z8k-*-*
+#skip: ia64-*-* mips*-*-freebsd* mips*-*-gnu* mips*-*-irix* mips*-*-kfreebsd*
+#skip: mips*-*-linux* mips*-*-netbsd* mips*-*-openbsd* mips*-*-sysv4*
+#skip: tilegx*-*-* tilepro-*-* x86_64-*-cygwin x86_64-*-mingw* x86_64-*-pe*
+#xfail: alpha*-*-*ecoff m32c-*-* sh-*-pe sparc*-*-coff
+#xfail: tic30-*-coff tic4x-*-* tic54x-*-* z8k-*-*
 #
-# See also fill16.d.  We use `notarget' for configurations unsupported
+# See also fill16.d.  We use `skip' for configurations unsupported
 # here that are covered there, and `xfail' for configurations that work
 # in neither place.  See below for details as to why individual
 # configurations are listed above.

diff --git a/ld/testsuite/ld-scripts/fill16.d b/ld/testsuite/ld-scripts/fill16.d
index 371f38e785c40928ba551871f8276a4f7a681e3c..693b80c5f1ce9ffed19d63ec1a59454f781f26e0 100644 (file)
--- a/ld/testsuite/ld-scripts/fill16.d
+++ b/ld/testsuite/ld-scripts/fill16.d
@@ -3,10 +3,11 @@
 #source: fill16_2.s
 #ld: -T fill.t
 #objdump: -s -j .text
-#xfail: alpha*-*-*ecoff arm-*-coff i[3-7]86-*-coff m32c-*-* sh-*-pe
-#xfail: sparc*-*-coff tic30-*-coff tic4x-*-* tic54x-*-* z8k-*-*
+#skip: arm-*-coff i[3-7]86-*-coff
+#xfail: alpha*-*-*ecoff m32c-*-* sh-*-pe sparc*-*-coff
+#xfail: tic30-*-coff tic4x-*-* tic54x-*-* z8k-*-*
 #
-# See also fill.d.  We use `notarget' for configurations unsupported
+# See also fill.d.  We use `skip' for configurations unsupported
 # here that are covered there, and `xfail' for configurations that work
 # with neither place.  See below for details as to why individual
 # configurations are listed above.