In the 'info -q -t' patch series, I started a new test from
gdb.threads/threadapply.exp, that uses an obsolete way to do
runto_main.
This patch changes all occurrences of runto_main using gdb_suppress_tests
to use instead fail+return.
Note that there are still about 220 occurrences of gdb_suppress_tests
but unclear (to me) if these can be similarly trivially be replaced by a
fail+return. Further cleanup can be done in follow-up patches.
Tests run on Debian/x86_64.
gdb/testsuite/ChangeLog
2018-10-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
* gdb.arch/altivec-regs.exp: Do not use gdb_suppress_tests in
runto_main, use fail + return instead.
gdb.arch/amd64-byte.exp: Likewise.
gdb.arch/amd64-dword.exp: Likewise.
gdb.arch/amd64-word.exp: Likewise.
gdb.arch/e500-abi.exp: Likewise.
gdb.arch/e500-regs.exp: Likewise.
gdb.arch/gdb1291.exp: Likewise.
gdb.arch/gdb1431.exp: Likewise.
gdb.arch/i386-avx.exp: Likewise.
gdb.arch/i386-byte.exp: Likewise.
gdb.arch/i386-prologue.exp: Likewise.
gdb.arch/i386-sse.exp: Likewise.
gdb.arch/i386-word.exp: Likewise.
gdb.arch/iwmmxt-regs.exp: Likewise.
gdb.arch/pa-nullify.exp: Likewise.
gdb.arch/powerpc-prologue.exp: Likewise.
gdb.arch/s390-tdbregs.exp: Likewise.
gdb.arch/vsx-regs.exp: Likewise.
gdb.asm/asm-source.exp: Likewise.
gdb.base/auxv.exp: Likewise.
gdb.base/bigcore.exp: Likewise.
gdb.base/overlays.exp: Likewise.
gdb.base/savedregs.exp: Likewise.
gdb.base/setshow.exp: Likewise.
gdb.base/sigaltstack.exp: Likewise.
gdb.base/sigbpt.exp: Likewise.
gdb.base/siginfo-addr.exp: Likewise.
gdb.base/siginfo-obj.exp: Likewise.
gdb.base/siginfo-thread.exp: Likewise.
gdb.base/siginfo.exp: Likewise.
gdb.base/signull.exp: Likewise.
gdb.base/sigrepeat.exp: Likewise.
gdb.base/structs2.exp: Likewise.
gdb.threads/threadapply.exp: Likewise.
gdb.threads/watchthreads.exp: Likewise.
gdb.threads/watchthreads2.exp: Likewise.
#
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
gdb_test "set print frame-arguments all"
clean_restart ${binfile}
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
set byte_regs(1) al
clean_restart ${binfile}
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
set nr_regs 14
clean_restart ${binfile}
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
set nr_regs 14
#
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
gdb_test "b marker" "Breakpoint 2 at.*file.*e500-abi.c, line \[0-9\]+." "break marker"
#
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
# set all the registers integer portions to 1
gdb_reinitialize_dir $srcdir/$subdir
gdb_load ${binfile}
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
gdb_test "break vector_fun" \
#
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
gdb_test "b sub1" "Breakpoint 2.*" "set breakpoint"
#
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
gdb_test "advance sub1" "hello world\r\n$hex in sub1 \\(\\)" "get to sub1"
clean_restart ${binfile}
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
send_gdb "print have_avx ()\r"
clean_restart ${binfile}
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
set byte_regs(1) al
#
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
# Testcase for standard prologue.
clean_restart ${binfile}
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
send_gdb "print have_sse ()\r"
clean_restart ${binfile}
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
set word_regs(1) ax
#
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
# Set all the registers to arbitrary values.
return $addr
}
-if { ! [ runto_main ] } then { gdb_suppress_tests; }
+if ![runto_main] then {
+ fail "can't run to main"
+ return 0
+}
set foo [get_addr_of_sym "foo"]
set bar [get_addr_of_sym "bar"]
}
set test "core at last insn in foo"
-if { ! [ runto_main ] } then { gdb_suppress_tests; }
+if ![runto_main] then {
+ fail "can't run to main"
+ return 0
+}
gdb_breakpoint "*$foo_last"
gdb_test "continue" "Breakpoint \[0-9\]*,.* in foo.*" "$test: continue to breakpoint"
if [gen_core $test] {
}
set test "core at nullified insn"
-if { ! [ runto_main ] } then { gdb_suppress_tests; }
+if ![runto_main] then {
+ fail "can't run to main"
+ return 0
+}
gdb_breakpoint "*$foo_last"
gdb_test "continue" "Breakpoint \[0-9\]*,.* in foo.*" "$test: continue to breakpoint"
gdb_test "stepi" ".*in foo.*" "$test: step to nullified instruction"
#
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
# Testcase for PIC prologue.
return -1
}
-if { ![runto_main] } then {
- gdb_suppress_tests
+if ![runto_main] then {
+ fail "can't run to main"
+ return 0
}
gdb_test_multiple "next" "check for TE support" {
# Run to `main' where we begin our tests.
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
set endianness [get_endianness]
#
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
# Execute the `f' command and see if the result includes source info.
}
}
-if { ![runto_main] } then {
- gdb_suppress_tests
+if ![runto_main] then {
+ fail "can't run to main"
+ return 0
}
set print_core_line [gdb_get_line_number "ABORT;"]
gdb_test "tbreak $print_core_line"
"cd to test directory"
}
-if { ![runto_main] } then {
- gdb_suppress_tests
+if ![runto_main] then {
+ fail "can't run to main"
+ return 0
}
set print_core_line [gdb_get_line_number "Dump core"]
gdb_test "tbreak $print_core_line"
#
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
# couple of convenience variables
clean_restart ${binfile}
# Advance to main
-if { ![runto_main] } {
- gdb_suppress_tests
+if ![runto_main] then {
+ fail "can't run to main"
+ return 0
}
proc process_saved_regs { current inner outer } {
clean_restart ${binfile}
# make sure $pc is sane, in case we're talking to a board.
-if { ![runto_main] } {
- gdb_suppress_tests
+if ![runto_main] then {
+ fail "can't run to main"
+ return 0
}
#
gdb_test "handle SIGPROF print pass nostop"
# Advance to main
-if { ![runto_main] } then {
- gdb_suppress_tests
+if ![runto_main] then {
+ fail "can't run to main"
+ return 0
}
# Stop in handle, when at the inner most level
#
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
# If we can examine what's at memory address 0, it is possible that we
gdb_test "display/i \$pc"
# Advance to main
-if { ![runto_main] } then {
- gdb_suppress_tests
+if ![runto_main] then {
+ fail "can't run to main"
+ return 0
}
# Run to the signal.
}
# Advance to main
-if { ![runto_main] } then {
- gdb_suppress_tests
+if ![runto_main] then {
+ fail "can't run to main"
+ return 0
}
# Run to the signal.
# the changed value.
# Advance to main
-if { ![runto_main] } then {
- gdb_suppress_tests
+if ![runto_main] then {
+ fail "can't run to main"
+ return 0
}
# Run to the signal.
clean_restart $binfile
# Advance to main
-if { ![runto_main] } then {
- gdb_suppress_tests
+if ![runto_main] then {
+ fail "can't run to main"
+ return 0
}
# Run to the signal.
gdb_test "display/i \$pc"
# Advance to main
-if { ![runto_main] } then {
- gdb_suppress_tests
+if ![runto_main] then {
+ fail "can't run to main"
+ return 0
}
# Pass all the alarms straight through (but verbosely)
#
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
# If we can examine what's at memory address 0, it is possible that we
clean_restart ${binfile}
# Advance to main
-if { ![runto_main] } then {
- gdb_suppress_tests
+if ![runto_main] then {
+ fail "can't run to main"
+ return 0
}
# Run to the signal handler wait loop.
gdb_test_no_output "set width 0"
-if { ![runto_main] } then {
- gdb_suppress_tests
+if ![runto_main] then {
+ fail "can't run to main"
+ return 0
}
# Ok, we're finally ready to actually do our tests.
#
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
# Break after all threads have been started.
#
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
set args_0 0
#
if ![runto_main] then {
- gdb_suppress_tests
+ fail "can't run to main"
+ return 0
}
gdb_test "break thread_started" \
projects / binutils-gdb.git / commitdiff