gdb: remove target_is_pushed free function

Same principle as the previous patches.

gdb/ChangeLog:

	* target.h (target_is_pushed): Remove, update callers to use
	inferior::target_is_pushed instead.
	* target.c (target_is_pushed): Remove.

Change-Id: I9862e6205acc65672da807cbe4b46cde009e7b9d

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 274e157905d71fcf06f46e26cbaaf00b3642046b..b6639ee77ada59a75ffd850c95f88cacd5fcf7f8 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2021-03-23  Simon Marchi  <simon.marchi@polymtl.ca>
+
+       * target.h (target_is_pushed): Remove, update callers to use
+       inferior::target_is_pushed instead.
+       * target.c (target_is_pushed): Remove.
+
 2021-03-23  Simon Marchi  <simon.marchi@polymtl.ca>
 
        * target.h (push_target): Remove, update callers to use

diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c
index f8e4443ff408f14388ecf8674b420e385864511f..587f53174163235fbe00a91a65067f513bbd5ad8 100644 (file)
--- a/gdb/darwin-nat.c
+++ b/gdb/darwin-nat.c
@@ -1658,7 +1658,7 @@ darwin_attach_pid (struct inferior *inf)
     }
 
   target_ops *darwin_ops = get_native_target ();
-  if (!target_is_pushed (darwin_ops))
+  if (!inf->target_is_pushed (darwin_ops))
     inf->push_target (darwin_ops);
 }
 

diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c
index 9ea4c408934054d230fb001e68d28e17d3031bb1..816f901ce23e2292461c494a51ada51013869c43 100644 (file)
--- a/gdb/gnu-nat.c
+++ b/gdb/gnu-nat.c
@@ -2109,12 +2109,13 @@ gnu_nat_target::create_inferior (const char *exec_file,
                                 int from_tty)
 {
   struct inf *inf = cur_inf ();
+  inferior *inferior = current_inferior ();
   int pid;
 
   inf_debug (inf, "creating inferior");
 
-  if (!target_is_pushed (this))
-    current_inferior ()->push_target (this);
+  if (!inf->target_is_pushed (this))
+    inf->push_target (this);
 
   pid = fork_inferior (exec_file, allargs, env, gnu_ptrace_me,
                       NULL, NULL, NULL, NULL);

diff --git a/gdb/go32-nat.c b/gdb/go32-nat.c
index 79c31fcd98771d89051f495be7b704d74644dd0c..9899545a1e218d948db4632c336eb653b3ae6de3 100644 (file)
--- a/gdb/go32-nat.c
+++ b/gdb/go32-nat.c
@@ -756,7 +756,7 @@ go32_nat_target::create_inferior (const char *exec_file,
   inf = current_inferior ();
   inferior_appeared (inf, SOME_PID);
 
-  if (!target_is_pushed (this))
+  if (!inf->target_is_pushed (this))
     inf->push_target (this);
 
   thread_info *thr = add_thread_silent (ptid_t (SOME_PID));

diff --git a/gdb/inf-ptrace.c b/gdb/inf-ptrace.c
index e630ba447f40ae7b983293ffcc63b6e463227a18..b6fa71fd2c0b08e97acd9a619a3419c8cbb014ea 100644 (file)
--- a/gdb/inf-ptrace.c
+++ b/gdb/inf-ptrace.c
@@ -74,15 +74,17 @@ inf_ptrace_target::create_inferior (const char *exec_file,
                                    const std::string &allargs,
                                    char **env, int from_tty)
 {
+  inferior *inf = current_inferior ();
+
   /* Do not change either targets above or the same target if already present.
      The reason is the target stack is shared across multiple inferiors.  */
-  int ops_already_pushed = target_is_pushed (this);
+  int ops_already_pushed = inf->target_is_pushed (this);
 
   target_unpush_up unpusher;
   if (! ops_already_pushed)
     {
       /* Clear possible core file with its process_stratum.  */
-      current_inferior ()->push_target (this);
+      inf->push_target (this);
       unpusher.reset (this);
     }
 
@@ -127,20 +129,17 @@ inf_ptrace_target::mourn_inferior ()
 void
 inf_ptrace_target::attach (const char *args, int from_tty)
 {
-  pid_t pid;
-  struct inferior *inf;
+  inferior *inf = current_inferior ();
 
   /* Do not change either targets above or the same target if already present.
      The reason is the target stack is shared across multiple inferiors.  */
-  int ops_already_pushed = target_is_pushed (this);
+  int ops_already_pushed = inf->target_is_pushed (this);
 
-  pid = parse_pid_to_attach (args);
+  pid_t pid = parse_pid_to_attach (args);
 
   if (pid == getpid ())                /* Trying to masturbate?  */
     error (_("I refuse to debug myself!"));
 
-  inf = current_inferior ();
-
   target_unpush_up unpusher;
   if (! ops_already_pushed)
     {

diff --git a/gdb/nto-procfs.c b/gdb/nto-procfs.c
index b74392fef3201e252869db19e4a3a14eb86db5e2..41b436cfa27fc2b2ff3aeca583cf1b811fcf5e3f 100644 (file)
--- a/gdb/nto-procfs.c
+++ b/gdb/nto-procfs.c
@@ -717,7 +717,7 @@ nto_procfs_target::attach (const char *args, int from_tty)
   inferior_appeared (inf, pid);
   inf->attach_flag = 1;
 
-  if (!target_is_pushed (ops))
+  if (!inf->target_is_pushed (ops))
     inf->push_target (ops);
 
   update_thread_list ();
@@ -1318,7 +1318,7 @@ nto_procfs_target::create_inferior (const char *exec_file,
       /* warning( "Failed to set Kill-on-Last-Close flag: errno = %d(%s)\n",
         errn, safe_strerror(errn) ); */
     }
-  if (!target_is_pushed (ops))
+  if (!inf->target_is_pushed (ops))
     inf->push_target (ops);
   target_terminal::init ();
 

diff --git a/gdb/procfs.c b/gdb/procfs.c
index b37680923cd84e0298ab1809747e4bf08535e79f..91d2039e3f9a46d64afd12d1e971efc5324185ef 100644 (file)
--- a/gdb/procfs.c
+++ b/gdb/procfs.c
@@ -1769,7 +1769,7 @@ procfs_target::attach (const char *args, int from_tty)
 
   /* Push the target if needed, ensure it gets un-pushed it if attach fails.  */
   target_unpush_up unpusher;
-  if (!target_is_pushed (this))
+  if (!inf->target_is_pushed (this))
     {
       current_inferior ()->push_target (this);
       unpusher.reset (this);
@@ -2862,7 +2862,7 @@ procfs_target::create_inferior (const char *exec_file,
       shell_file = tryname;
     }
 
-  if (!target_is_pushed (this))
+  if (!inf->target_is_pushed (this))
     current_inferior ()->push_target (this);
 
   pid = fork_inferior (exec_file, allargs, env, procfs_set_exec_trap,

diff --git a/gdb/target.c b/gdb/target.c
index fe9731221efd7048183d61c785de9b332ad6126d..afc4b2cbbb601585c16547f4bc59a724bbf91eb0 100644 (file)
--- a/gdb/target.c
+++ b/gdb/target.c
@@ -647,15 +647,6 @@ pop_all_targets (void)
   pop_all_targets_above (dummy_stratum);
 }
 
-/* Return true if T is now pushed in the current inferior's target
-   stack.  Return false otherwise.  */
-
-bool
-target_is_pushed (target_ops *t)
-{
-  return current_inferior ()->target_is_pushed (t);
-}
-
 void
 target_unpusher::operator() (struct target_ops *ops) const
 {
@@ -3097,7 +3088,7 @@ debug_target::info () const
 void
 target_close (struct target_ops *targ)
 {
-  gdb_assert (!target_is_pushed (targ));
+  gdb_assert (!current_inferior ()->target_is_pushed (targ));
 
   fileio_handles_invalidate_target (targ);
 

diff --git a/gdb/target.h b/gdb/target.h
index 1830d3a8106f7c58d252029af75e554170aa918c..6b71e741f6d7c55ec595dfa7c299e9e51d68527c 100644 (file)
--- a/gdb/target.h
+++ b/gdb/target.h
@@ -2411,8 +2411,6 @@ extern void pop_all_targets_at_and_above (enum strata stratum);
    strictly above ABOVE_STRATUM.  */
 extern void pop_all_targets_above (enum strata above_stratum);
 
-extern bool target_is_pushed (target_ops *t);
-
 extern CORE_ADDR target_translate_tls_address (struct objfile *objfile,
                                               CORE_ADDR offset);
 

diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index 51662896d691c65d6ec5e18d2f0004bd5a2b7c71..00f83536e330beb16daf6707eb910777a514dc13 100644 (file)
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -2028,7 +2028,7 @@ windows_nat_target::do_initial_windows_stuff (DWORD pid, bool attaching)
   current_event.dwProcessId = pid;
   memset (&current_event, 0, sizeof (current_event));
   inf = current_inferior ();
-  if (!target_is_pushed (this))
+  if (!inf->target_is_pushed (this))
     inf->push_target (this);
   disable_breakpoints_in_shlibs ();
   windows_clear_solib ();