nv50, nvc0: fix must_check warning of util_dynarray_resize_bytes
authorKarol Herbst <kherbst@redhat.com>
Fri, 20 Sep 2019 18:27:20 +0000 (20:27 +0200)
committerMarge Bot <eric+marge@anholt.net>
Fri, 27 Mar 2020 18:20:20 +0000 (18:20 +0000)
Signed-off-by: Karol Herbst <kherbst@redhat.com>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4330>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4330>

src/gallium/drivers/nouveau/nv50/nv50_state.c
src/gallium/drivers/nouveau/nvc0/nvc0_state.c

index 6488c71f4ad8a307b0c023241ebd99b4d82c9f89..c176fa6fe935544467084fc757ab80e9ba417cad 100644 (file)
@@ -1267,9 +1267,13 @@ nv50_set_global_bindings(struct pipe_context *pipe,
 
    if (nv50->global_residents.size <= (end * sizeof(struct pipe_resource *))) {
       const unsigned old_size = nv50->global_residents.size;
-      util_dynarray_resize(&nv50->global_residents, struct pipe_resource *, end);
-      memset((uint8_t *)nv50->global_residents.data + old_size, 0,
-             nv50->global_residents.size - old_size);
+      if (util_dynarray_resize(&nv50->global_residents, struct pipe_resource *, end)) {
+         memset((uint8_t *)nv50->global_residents.data + old_size, 0,
+                nv50->global_residents.size - old_size);
+      } else {
+         NOUVEAU_ERR("Could not resize global residents array\n");
+         return;
+      }
    }
 
    if (resources) {
index 49546e5de68b60afeef83a9ff99f42ef85d09661..d53a6cb2a267fa7d90ab2d3cd7e1a9a7bfa894c0 100644 (file)
@@ -1384,9 +1384,13 @@ nvc0_set_global_bindings(struct pipe_context *pipe,
 
    if (nvc0->global_residents.size <= (end * sizeof(struct pipe_resource *))) {
       const unsigned old_size = nvc0->global_residents.size;
-      util_dynarray_resize(&nvc0->global_residents, struct pipe_resource *, end);
-      memset((uint8_t *)nvc0->global_residents.data + old_size, 0,
-             nvc0->global_residents.size - old_size);
+      if (util_dynarray_resize(&nvc0->global_residents, struct pipe_resource *, end)) {
+         memset((uint8_t *)nvc0->global_residents.data + old_size, 0,
+                nvc0->global_residents.size - old_size);
+      } else {
+         NOUVEAU_ERR("Could not resize global residents array\n");
+         return;
+      }
    }
 
    if (resources) {