egl/x11: don't leak xfixes_query in the error path
authorEmil Velikov <emil.velikov@collabora.com>
Thu, 3 Aug 2017 13:34:53 +0000 (14:34 +0100)
committerEmil Velikov <emil.l.velikov@gmail.com>
Fri, 4 Aug 2017 22:56:33 +0000 (23:56 +0100)
If we get a xfixes v1.x we'll error out, without freeing the
xfixes_query reply.

Cc: <mesa-stable@lists.freedesktop.org>
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
src/egl/drivers/dri2/platform_x11.c

index 35c62a4975aaccd69228c29873f6b795a857d1cc..61e700f7ecbaad19a2be347c5435ca40d1505b43 100644 (file)
@@ -646,6 +646,7 @@ dri2_x11_connect(struct dri2_egl_display *dri2_dpy)
        error != NULL || xfixes_query->major_version < 2) {
       _eglLog(_EGL_WARNING, "DRI2: failed to query xfixes version");
       free(error);
+      free(xfixes_query);
       return EGL_FALSE;
    }
    free(xfixes_query);