command: remove success/failed redundancy (keep failed)

diff --git a/litesata/common.py b/litesata/common.py
index 235c9065ed6e9d48839fc44d1d7a9d1acf9f0795..18f5603c95e3f149398a0ed7ea7ba06c31e14776 100644 (file)
--- a/litesata/common.py
+++ b/litesata/common.py
@@ -214,7 +214,6 @@ def command_rx_description(dw):
                ("read", 1),
                ("identify", 1),
                ("last", 1),
-               ("success", 1),
                ("failed", 1),
                ("data", dw)
        ]
@@ -226,7 +225,6 @@ def command_rx_cmd_description(dw):
                ("read", 1),
                ("identify", 1),
                ("last", 1),
-               ("success", 1),
                ("failed", 1)
        ]
        return EndpointDescription(layout, packetized=False)

diff --git a/litesata/core/command/__init__.py b/litesata/core/command/__init__.py
index f614415bb3a4aadb91ce46dd949d4cb7752253bd..3a330839938870b1ffcb97ad7ebcaeba8de2e06f 100644 (file)
--- a/litesata/core/command/__init__.py
+++ b/litesata/core/command/__init__.py
@@ -192,7 +192,6 @@ class LiteSATACommandRX(Module):
                        source.eop.eq(1),
                        source.write.eq(1),
                        source.last.eq(1),
-                       source.success.eq(~transport.source.error & ~d2h_error),
                        source.failed.eq(transport.source.error | d2h_error),
                        If(source.stb & source.ack,
                                NextState("IDLE")
@@ -232,7 +231,6 @@ class LiteSATACommandRX(Module):
                        source.eop.eq(transport.source.eop),
                        source.read.eq(~is_identify),
                        source.identify.eq(is_identify),
-                       source.success.eq(~transport.source.error),
                        source.failed.eq(transport.source.error),
                        source.last.eq(is_identify),
                        source.data.eq(transport.source.data),
@@ -255,7 +253,6 @@ class LiteSATACommandRX(Module):
                        source.eop.eq(1),
                        source.read.eq(1),
                        source.last.eq(1),
-                       source.success.eq(read_done & ~read_error & ~d2h_error),
                        source.failed.eq(~read_done | read_error | d2h_error),
                        If(source.stb & source.ack,
                                NextState("IDLE")

diff --git a/litesata/test/command_tb.py b/litesata/test/command_tb.py
index 0b9d53a00dcb24c3a288bf41568b6681952f673c..566902fd8c00e28b391150aafb2c497895c7e7b7 100644 (file)
--- a/litesata/test/command_tb.py
+++ b/litesata/test/command_tb.py
@@ -32,7 +32,6 @@ class CommandRXPacket(list):
                self.done = False
                self.write = 0
                self.read = 0
-               self.success = 0
                self.failed = 0
 
 class CommandLogger(PacketLogger):
@@ -45,7 +44,6 @@ class CommandLogger(PacketLogger):
                        self.packet = CommandRXPacket()
                        self.packet.write = selfp.sink.write
                        self.packet.read = selfp.sink.read
-                       self.packet.sucess = selfp.sink.success
                        self.packet.failed = selfp.sink.failed
                        self.packet.append(selfp.sink.data)
                elif selfp.sink.stb:

diff --git a/targets/bist.py b/targets/bist.py
index 29581b28286a3e05463adffc9bf7cccbe8615e40..717ae7b19ff712b8301d1c4d362ca45dd5e2bff3 100644 (file)
--- a/targets/bist.py
+++ b/targets/bist.py
@@ -187,7 +187,6 @@ class BISTSoCDevel(BISTSoC, AutoCSR):
                        self.sata.core.command.source.write,
                        self.sata.core.command.source.read,
                        self.sata.core.command.source.identify,
-                       self.sata.core.command.source.success,
                        self.sata.core.command.source.failed,
                        self.sata.core.command.source.data,