mesa: Leave aliasing of vertex and generic0 attribute to the dlist code.
authorMathias Fröhlich <mathias.froehlich@web.de>
Mon, 29 Apr 2019 05:23:58 +0000 (07:23 +0200)
committerMathias Fröhlich <mathias.froehlich@web.de>
Sat, 4 May 2019 05:40:35 +0000 (07:40 +0200)
Now that dlist compilation again knows if it is inside glBegin/glEnd,
we can leave the decision if aliasing should occur to the vertex attribute
setter functions instead of doing that at glArrayElement time.

Reviewed-by: Brian Paul <brianp@vmware.com>
Signed-off-by: Mathias Fröhlich <Mathias.Froehlich@web.de>
src/mesa/main/api_arrayelt.c

index 6e3678398344bcf9eea90f12d7fad2778aedce82..51a7d63b83e93ae26f75c01a18c2eab966f64854 100644 (file)
@@ -1450,10 +1450,7 @@ _mesa_array_element(struct gl_context *ctx, GLint elt)
       const gl_vert_attrib attrib = VERT_ATTRIB_GENERIC0;
       const struct gl_array_attributes *array = &vao->VertexAttrib[attrib];
       const void *src = attrib_src(vao, array, elt);
-      /* Use glVertex(v) instead of glVertexAttrib(0, v) to be sure it's
-       * issued as the last (provoking) attribute).
-       */
-      func_nv(&array->Format)(0, src);
+      func_arb(&array->Format)(0, src);
    } else if (vao->Enabled & VERT_BIT_POS) {
       const gl_vert_attrib attrib = VERT_ATTRIB_POS;
       const struct gl_array_attributes *array = &vao->VertexAttrib[attrib];