Re: dependency list for static libraries

This feature doesn't actually require plugin support, that was a
mistake in the previous patch.  Fixes these fails:

hppa-hp-hpux10  +FAIL: ar adding library dependencies
i386-bsd  +FAIL: ar adding library dependencies
i386-msdos  +FAIL: ar adding library dependencies
ns32k-netbsd  +FAIL: ar adding library dependencies
ns32k-pc532-mach  +FAIL: ar adding library dependencies
pdp11-dec-aout  +FAIL: ar adding library dependencies

	* ar.c (main): Use plugin_target rather than "target" when
	resetting libdeps_bfd target.

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 2aa6a3276244e63447ec48e4153e947369999f31..2e24fafb7678115c37f514045709114025f2f617 100644 (file)
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,8 @@
+2020-11-09  Howard Chu  <hyc@symas.com>
+
+       * ar.c (main): Use plugin_target rather than "target" when
+       resetting libdeps_bfd target.
+
 2020-11-06  H.J. Lu  <hongjiu.lu@intel.com>
 
        * elfedit.c: Include "libiberty.h".

diff --git a/binutils/ar.c b/binutils/ar.c
index 56c758cc1af010c0d9689ea870c8c8d08a937749..537b139e98f4c309aa6dab6d6d0ef6d677454dfd 100644 (file)
--- a/binutils/ar.c
+++ b/binutils/ar.c
@@ -866,7 +866,7 @@ main (int argc, char **argv)
          /* Create a bfd to contain the dependencies.
             It inherits its type from arch, but we must set the type to
             "binary" otherwise bfd_bwrite() will fail.  After writing, we
-            must set the type back to "plugin" otherwise adding it to the
+            must set the type back to default otherwise adding it to the
             archive will fail.  */
          libdeps_bfd = bfd_create (LIBDEPS, arch);
          if (libdeps_bfd == NULL)
@@ -887,7 +887,7 @@ main (int argc, char **argv)
          if (! bfd_make_readable (libdeps_bfd))
            fatal (_("Cannot make libdeps object readable."));
 
-         if (bfd_find_target ("plugin", libdeps_bfd) == NULL)
+         if (bfd_find_target (plugin_target, libdeps_bfd) == NULL)
            fatal (_("Cannot reset libdeps record type."));
 
          /* Append our libdeps record to the list of files