Rename to allow_gdbserver_tests
authorTom Tromey <tom@tromey.com>
Sun, 8 Jan 2023 17:53:55 +0000 (10:53 -0700)
committerTom Tromey <tom@tromey.com>
Fri, 13 Jan 2023 20:18:57 +0000 (13:18 -0700)
This changes skip_gdbserver_tests to invert the sense, and renames it
to allow_gdbserver_tests.

39 files changed:
gdb/testsuite/gdb.btrace/enable.exp
gdb/testsuite/gdb.btrace/reconnect.exp
gdb/testsuite/gdb.mi/mi-file-transfer.exp
gdb/testsuite/gdb.multi/attach-no-multi-process.exp
gdb/testsuite/gdb.multi/multi-target.exp.tcl
gdb/testsuite/gdb.python/py-send-packet.exp
gdb/testsuite/gdb.server/abspath.exp
gdb/testsuite/gdb.server/attach-flag.exp
gdb/testsuite/gdb.server/bkpt-other-inferior.exp
gdb/testsuite/gdb.server/connect-stopped-target.exp
gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp
gdb/testsuite/gdb.server/connect-without-multi-process.exp
gdb/testsuite/gdb.server/exit-multiple-threads.exp
gdb/testsuite/gdb.server/ext-attach.exp
gdb/testsuite/gdb.server/ext-restart.exp
gdb/testsuite/gdb.server/ext-run.exp
gdb/testsuite/gdb.server/ext-wrapper.exp
gdb/testsuite/gdb.server/file-transfer.exp
gdb/testsuite/gdb.server/monitor-exit-quit.exp
gdb/testsuite/gdb.server/multi-ui-errors.exp
gdb/testsuite/gdb.server/no-thread-db.exp
gdb/testsuite/gdb.server/non-existing-program.exp
gdb/testsuite/gdb.server/reconnect-ctrl-c.exp
gdb/testsuite/gdb.server/run-without-local-binary.exp
gdb/testsuite/gdb.server/server-connect.exp
gdb/testsuite/gdb.server/server-exec-info.exp
gdb/testsuite/gdb.server/server-kill-python.exp
gdb/testsuite/gdb.server/server-kill.exp
gdb/testsuite/gdb.server/server-mon.exp
gdb/testsuite/gdb.server/server-pipe.exp
gdb/testsuite/gdb.server/server-run.exp
gdb/testsuite/gdb.server/solib-list.exp
gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp
gdb/testsuite/gdb.server/stop-reply-no-thread.exp
gdb/testsuite/gdb.server/sysroot.exp
gdb/testsuite/gdb.server/twice-connect.exp
gdb/testsuite/gdb.server/unittest.exp
gdb/testsuite/gdb.server/wrapper.exp
gdb/testsuite/lib/gdbserver-support.exp

index acad4c6e82862053bfdc5f318e3e6407196e1438..113b8e18aad278944542314869893883efafc3e0 100644 (file)
@@ -70,13 +70,13 @@ gdb_test "record btrace" "The process is already being recorded\\.  Use \"record
 # continue to the end and make sure we don't die
 gdb_test "continue" ".*Inferior.*exited.*" "continue to end"
 
-# skip_gdbserver_tests requires GDB not running.
+# allow_gdbserver_tests requires GDB not running.
 gdb_exit
 
 # skip the rerun test when using gdbserver
 # otherwise rerun twice, target should be automatically disabled
 load_lib gdbserver-support.exp
-if [skip_gdbserver_tests] {
+if !{[allow_gdbserver_tests]} {
     unsupported "target does not support gdbserver"
     return 0
 }
index 1da9f4be566ea36075f1abdc3cd3bf39fb23bce9..2c8358327a4005c1d19a520fce78631f12049aa9 100644 (file)
@@ -20,7 +20,7 @@
 load_lib gdbserver-support.exp
 
 require allow_btrace_tests
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 standard_testfile
 if [prepare_for_testing "failed to prepare" $testfile $srcfile] {
index 71aa2f83cc07efa52090845ac4a8bf8c1d85f178..726504c46d8be32d4b7ca61ceb1940c86ed3d5bd 100644 (file)
@@ -20,7 +20,7 @@ load_lib gdbserver-support.exp
 load_lib mi-support.exp
 set MIFLAGS "-i=mi"
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 standard_testfile basics.c
 
index 50b04ad6761b1bd81f2a2a85473b052ba3946561..1ef7984078ad3ea3f365eed2b3fa150dd469f60b 100644 (file)
@@ -22,7 +22,7 @@ load_lib gdbserver-support.exp
 
 standard_testfile
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 require can_spawn_for_attach
 
index af9b564228ff2ed75d6d7bc7ddc2b9d844d35655..2356b6c8e6e3f4c1b3251862dd152e1ec0809c5d 100644 (file)
@@ -165,7 +165,7 @@ proc setup {non-stop} {
 proc multi_target_prepare {} {
     global binfile srcfile
 
-    if { [skip_gdbserver_tests] } {
+    if { ![allow_gdbserver_tests] } {
        return 0
     }
 
index e09dbb05fd48533133fc0f511787c93439c346ab..75e7bb6aa9cbc4c51e607a961376297c5768dc02 100644 (file)
@@ -24,7 +24,7 @@ load_lib gdbserver-support.exp
 
 standard_testfile
 
-require !skip_gdbserver_tests !skip_python_tests
+require allow_gdbserver_tests !skip_python_tests
 
 if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } {
     return -1
index 58d9b39efc1f72ae7eb436992ad8928d03c7a5e7..46657c65e8f61bf09e6d917470880f4df1085832 100644 (file)
@@ -22,7 +22,7 @@ load_lib gdbserver-support.exp
 
 standard_testfile normal.c
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 # Because we're relying on being able to change our CWD before
 # executing gdbserver, we just run if we're not testing with a remote
index bb6f3673e4ef7c1c5c32e587a1445db68d387216..ad67303a7ddcfcbde30aca5af09062da56483ea8 100644 (file)
@@ -21,7 +21,7 @@ load_lib gdbserver-support.exp
 
 standard_testfile
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 require can_spawn_for_attach
 
index fe561d8e924c90f2a720a8f74a998fa3d10c38ae..d4395d2c44115c9d7b6314e317bb09b6dac91929 100644 (file)
@@ -21,7 +21,7 @@ load_lib gdbserver-support.exp
 
 standard_testfile server.c
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 if { [prepare_for_testing "failed to prepare" ${binfile} "${srcfile}" \
          {debug pthreads}] } {
index ed193f8599c71abfe271eb7c01898345f5685576..2dfe2ea94ac227f12d194a096c0e13f6b5582ec9 100644 (file)
@@ -20,7 +20,7 @@
 load_lib gdbserver-support.exp
 load_lib prelink-support.exp
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 standard_testfile
 set executable ${testfile}
index 159f82f6c3b49ee49aad652b52c13a4b4a762aa4..b98e566e2d699a7f90e46b281267dc087ccb24bc 100644 (file)
@@ -25,7 +25,7 @@ load_lib gdbserver-support.exp
 
 standard_testfile
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 if { [build_executable "failed to prepare" $testfile $srcfile debug] } {
     return -1
index 831ccd6f876ecc5ca57ce76ee47700378cf00016..fcd64c9f49abce851539773a1cd748a1e2c9465f 100644 (file)
@@ -18,7 +18,7 @@
 
 load_lib gdbserver-support.exp
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 standard_testfile
 
index 88c4df11ccd0188e29f80ab5d0d25e4838d3241e..46239e3eabf3e8a6b73bbea0ea8ce8e91cbd44f8 100644 (file)
@@ -25,7 +25,7 @@
 
 load_lib gdbserver-support.exp
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 standard_testfile
 
index 81b324d4c5faa672e6a7738c1f9642eaeaa8f247..f7092b0340cdd4513cbd061eabe8cf08c427fedb 100644 (file)
@@ -22,7 +22,7 @@ load_lib trace-support.exp
 
 standard_testfile
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 require can_spawn_for_attach
 
index df26c91fa25350443c43943932d65461de980dc0..5b6aa7038f2fccda723a46f564ec644088b2207d 100644 (file)
@@ -21,7 +21,7 @@ load_lib gdbserver-support.exp
 
 standard_testfile server.c
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 save_vars { GDBFLAGS } {
     # If GDB and GDBserver are both running locally, set the sysroot to avoid
index 2add84e8b1b01f8308bfd33eee47e45c07087d98..59ead666d7b8127110ba88296c82d8a5633ece14 100644 (file)
@@ -21,7 +21,7 @@ load_lib gdbserver-support.exp
 
 standard_testfile server.c
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
     return -1
index 4f150cfc0a510c2696fd1c7b0709a2c77979ea40..2fe601a81aa89acc21bd4168897c9e6a2ed47c6b 100644 (file)
@@ -19,7 +19,7 @@ load_lib gdbserver-support.exp
 
 standard_testfile wrapper.c
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
     return -1
index cd98ffee90dd568e025f788f2d56b3b659d306ba..05da514413c32887e6164a9667a7646e6ba6b3eb 100644 (file)
@@ -20,7 +20,7 @@ load_lib gdbserver-support.exp
 
 standard_testfile server.c
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
     return -1
index 88eb2e483b987ae9e6c883088d30c862ef49374f..f253f82389642442958cb44686aa08353f73556d 100644 (file)
@@ -21,7 +21,7 @@ load_lib gdbserver-support.exp
 
 standard_testfile server.c
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
     return -1
index 95a08c9bca6f9973a7c8b6edaafc7da774594a11..9cc5239d888b97025b8a31f52e6c7a44350fbd58 100644 (file)
@@ -24,7 +24,7 @@ load_lib gdbserver-support.exp
 
 standard_testfile
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 save_vars { GDBFLAGS } {
     # If GDB and GDBserver are both running locally, set the sysroot to avoid
index 0e2fbae80bea245fa98ac9598b9eecf29b15a286..53d04753c40069a8bbfddd8716ce9baf09cba687 100644 (file)
@@ -25,7 +25,7 @@ load_lib gdbserver-support.exp
 standard_testfile
 set unresolvable_thread_db_path "/foo/bar"
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
     return -1
index 60ca0a43dfb59ffd9151bb934f9efbc559926ccf..32f27fa2b1cf723355f13adf2af417e3d4fe86ff 100644 (file)
@@ -22,7 +22,7 @@ load_lib gdbserver-support.exp
 
 standard_testfile
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 set gdbserver [find_gdbserver]
 if { $gdbserver == "" } {
index 42707692c4b3295f6a83ff5d8b691d14e40c2150..c8ef81443e57736a3c500e28c501253026d31fe2 100644 (file)
@@ -19,7 +19,7 @@
 
 load_lib gdbserver-support.exp
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 if [target_info exists gdb,nointerrupts] {
     verbose "Skipping reconnect-ctrl-c.exp because of nointerrupts."
index 4f3f0d9af4ee9bf7a3ee20445bb41eaa0321328a..c390eeb435a3f5f362a4a7862ef25b6870531188 100644 (file)
@@ -15,7 +15,7 @@
 
 load_lib gdbserver-support.exp
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 standard_testfile normal.c
 
index 76570f34232034a1a185c557548bb094d7961877..6c4c969c30d395edeb8067ff2ef6ffb0220eedf2 100644 (file)
@@ -22,7 +22,7 @@ load_lib gdbserver-support.exp
 
 standard_testfile normal.c
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 # We want to have control over where we start gdbserver.
 if { [is_remote target] } {
index a80c0f96480c6149eb10102c8831b4fc284be796..b1a392883b0789258b0006e9e6147bce727f2b2f 100644 (file)
@@ -18,7 +18,7 @@ load_lib gdbserver-support.exp
 # We test for skip_shlib_tests in this test because without a main
 # exec file we only have the exec target loaded if shared libraries
 # are present.
-require !skip_gdbserver_tests !skip_shlib_tests
+require allow_gdbserver_tests !skip_shlib_tests
 
 standard_testfile server.c
 if [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] {
index 4ef70daaf90306a22324f4e71416ed4f4c4eb5aa..bc62cbfc4317756a3e6853fde737b8d6f28ca05f 100644 (file)
@@ -23,7 +23,7 @@ load_lib gdbserver-support.exp
 
 standard_testfile multi-ui-errors.c
 
-require !skip_gdbserver_tests !skip_python_tests
+require allow_gdbserver_tests !skip_python_tests
 
 if {[build_executable "failed to prepare" ${testfile} \
         ${srcfile}] == -1} {
index 04b7f62561a40714b416b4bd91289801c6618405..b757369b71c0fc0423507c553aea88dac44312a2 100644 (file)
@@ -22,7 +22,7 @@ load_lib gdbserver-support.exp
 
 standard_testfile
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 if { [build_executable "failed to prepare" ${testfile}] } {
     return -1
index 4b728cb80384f7d6a32e25fbd31a86e70711d221..728cc84a9e040a8f127d597662f7a2b8e8634c4e 100644 (file)
@@ -21,7 +21,7 @@ load_lib gdbserver-support.exp
 
 standard_testfile server.c
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
     return -1
index 2038ca9140da7fb2c5199f164acbd9ab5c57b022..693771e942e6c36bf4815e6a487c463ff4490757 100644 (file)
@@ -32,7 +32,7 @@ load_lib gdbserver-support.exp
 
 standard_testfile
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 set gdbserver [find_gdbserver]
 if { $gdbserver == "" } {
index 55b40057f91c6f0ce7981b1d5daf06fcafe099f0..35f499f7d1a03f5c970fca5b0300347e8d5bb4e8 100644 (file)
@@ -21,7 +21,7 @@ load_lib gdbserver-support.exp
 
 standard_testfile server.c
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
     return -1
index f22ec8956c434d63d2a5e4df045db27b494d680d..ef99be747470ce7a4b163479ad82df5e4b9616a3 100644 (file)
@@ -23,7 +23,7 @@
 load_lib gdbserver-support.exp
 load_lib prelink-support.exp
 
-require !skip_gdbserver_tests !skip_shlib_tests
+require allow_gdbserver_tests !skip_shlib_tests
 
 standard_testfile solib-list-main.c
 set srclibfile ${testfile}-lib.c
index 066f2a1b73654281d74edf58fbb68de0cae9e8ec..20d45ba17dad9157fca98ae6b1cb61fc76b73764 100644 (file)
@@ -30,7 +30,7 @@
 
 load_lib gdbserver-support.exp
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 standard_testfile
 if { [build_executable "failed to prepare" $testfile $srcfile {debug pthreads}] == -1 } {
index 134ab6a9c29c9c31068da36b29a9d38f0de16fe0..848ada128f3cd82ad64414bb808e8b8ddb5bdb7d 100644 (file)
@@ -22,7 +22,7 @@
 
 load_lib gdbserver-support.exp
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 standard_testfile
 if { [build_executable "failed to prepare" $testfile $srcfile] == -1 } {
index 9845a7a83331f8f049a9f7d88f5e66f0e5342bf7..715d60010207aedf0a2fa670254abbf12df89a71 100644 (file)
@@ -20,7 +20,7 @@
 
 load_lib gdbserver-support.exp
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 standard_testfile
 if {[build_executable "failed to prepare" $testfile $srcfile "additional_flags=--no-builtin"] == -1} {
index a8318c0de4a66280a7524802216b21d748e41c2d..8ff8334f5f205bfd345f1560192971f250ea99b3 100644 (file)
@@ -19,7 +19,7 @@ load_lib gdbserver-support.exp
 
 standard_testfile
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 if { [build_executable "failed to prepare" $::testfile $::srcfile \
          {debug}] } {
index f727892fdc8d676d7312888e624a70576073c6b8..d25ee3626446426b22ed46b1863e07e53d9185b2 100644 (file)
@@ -19,7 +19,7 @@ load_lib gdbserver-support.exp
 
 standard_testfile
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 global server_spawn_id
 
index caaa4f69afbbbbd295f902c5c19c5e9176e041bc..ec985e0da2e37242a35ff126b844e8f8eed77d91 100644 (file)
@@ -21,7 +21,7 @@ load_lib gdbserver-support.exp
 
 standard_testfile
 
-require !skip_gdbserver_tests
+require allow_gdbserver_tests
 
 if { [istarget *-*-mingw*]
      || [istarget *-*-cygwin*] } {
index 49ae56190c25b22f3baf1e8d914716265c911fa6..30d94fd7eb619e095815770642448d4ded99ab54 100644 (file)
@@ -160,12 +160,12 @@ proc find_gdbserver { } {
   return ""
 }
 
-# Return non-zero if we should skip gdbserver-specific tests.
+# Return non-zero if we should run gdbserver-specific tests.
 
-proc skip_gdbserver_tests { } {
-  if { [find_gdbserver] == "" } {
-    return 1
-  }
+proc allow_gdbserver_tests { } {
+    if { [find_gdbserver] == "" } {
+       return 0
+    }
 
     # If GDB is lack of XML support, and targets, like arm, have
     # multiple target descriptions, GDB doesn't know which target
@@ -179,10 +179,10 @@ proc skip_gdbserver_tests { } {
             || [istarget "s390*-*-linux*"]
             || [istarget "x86_64-*-linux*"]
             || [istarget "i\[34567\]86-*-linux*"]) } {
-       return 1
+       return 0
     }
 
-  return 0
+    return 1
 }
 
 # Download the currently loaded program to the target if necessary.