spirv: add missing fallthrough comments
authorTimothy Arceri <tarceri@itsqueeze.com>
Wed, 1 Jul 2020 05:55:47 +0000 (15:55 +1000)
committerMarge Bot <eric+marge@anholt.net>
Thu, 2 Jul 2020 23:52:52 +0000 (23:52 +0000)
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5705>

src/compiler/spirv/vtn_subgroup.c

index 8d17845c1a0c420b83624b399c484c12dd2745f2..e8c3db79b9dad581dfd1473e4caed4073248f45d 100644 (file)
@@ -88,7 +88,7 @@ vtn_handle_subgroup(struct vtn_builder *b, SpvOp opcode,
       break;
    }
 
-   case SpvOpGroupNonUniformBallot: ++w;
+   case SpvOpGroupNonUniformBallot: ++w; /* fallthrough */
    case SpvOpSubgroupBallotKHR: {
       vtn_fail_if(val->type->type != glsl_vector_type(GLSL_TYPE_UINT, 4),
                   "OpGroupNonUniformBallot must return a uvec4");
@@ -177,14 +177,14 @@ vtn_handle_subgroup(struct vtn_builder *b, SpvOp opcode,
       break;
    }
 
-   case SpvOpGroupNonUniformBroadcastFirst: ++w;
+   case SpvOpGroupNonUniformBroadcastFirst: ++w; /* fallthrough */
    case SpvOpSubgroupFirstInvocationKHR:
       vtn_build_subgroup_instr(b, nir_intrinsic_read_first_invocation,
                                val->ssa, vtn_ssa_value(b, w[3]), NULL, 0, 0);
       break;
 
    case SpvOpGroupNonUniformBroadcast:
-   case SpvOpGroupBroadcast: ++w;
+   case SpvOpGroupBroadcast: ++w; /* fallthrough */
    case SpvOpSubgroupReadInvocationKHR:
       vtn_build_subgroup_instr(b, nir_intrinsic_read_invocation,
                                val->ssa, vtn_ssa_value(b, w[3]),