Change get_inferior_args to return const char *

I noticed that get_inferior_args should return const char *, because
it is just returning a reference to something owned by the inferior.

I'm checking this in.

gdb/ChangeLog
2018-09-15  Tom Tromey  <tom@tromey.com>

	* infcmd.c (get_inferior_args): Return const char *.
	* inferior.h (get_inferior_args): Return type now const.
	* linux-tdep.c (linux_fill_prpsinfo): Update.
	* procfs.c (procfs_target::make_corefile_notes): Update.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 80e1ccd51101ba8821cc5380087e5de7bcf05746..da9b450b28bcd529346b2f87bad98964d96e8544 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2018-09-15  Tom Tromey  <tom@tromey.com>
+
+       * infcmd.c (get_inferior_args): Return const char *.
+       * inferior.h (get_inferior_args): Return type now const.
+       * linux-tdep.c (linux_fill_prpsinfo): Update.
+       * procfs.c (procfs_target::make_corefile_notes): Update.
+
 2018-09-07  Tom Tromey  <tom@tromey.com>
 
        * python/python.c (execute_gdb_command): Call bpstat_do_actions

diff --git a/gdb/infcmd.c b/gdb/infcmd.c
index 860909f5e20ea0c898e0039a836f98c43a2c9b9b..047693ebb5c90d12e11c9c43d605ce5936c81359 100644 (file)
--- a/gdb/infcmd.c
+++ b/gdb/infcmd.c
@@ -154,7 +154,7 @@ show_inferior_tty_command (struct ui_file *file, int from_tty,
                      "is \"%s\".\n"), inferior_io_terminal);
 }
 
-char *
+const char *
 get_inferior_args (void)
 {
   if (current_inferior ()->argc != 0)

diff --git a/gdb/inferior.h b/gdb/inferior.h
index c5dc324fa3968e570069311c0c092dad22be2b99..8d38429838718f5f75f757991f943cff152ace86 100644 (file)
--- a/gdb/inferior.h
+++ b/gdb/inferior.h
@@ -161,7 +161,7 @@ extern void post_create_inferior (struct target_ops *, int);
 
 extern void attach_command (const char *, int);
 
-extern char *get_inferior_args (void);
+extern const char *get_inferior_args (void);
 
 extern void set_inferior_args (const char *);
 

diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c
index 5801ab5222fae8c54461efa458f9992d2d79e522..5bfd7ed92f9fa3e0f97541d50738c9c4021ebc71 100644 (file)
--- a/gdb/linux-tdep.c
+++ b/gdb/linux-tdep.c
@@ -1728,7 +1728,7 @@ linux_fill_prpsinfo (struct elf_internal_linux_prpsinfo *p)
   char filename[100];
   /* The basename of the executable.  */
   const char *basename;
-  char *infargs;
+  const char *infargs;
   /* Temporary buffer.  */
   char *tmpstr;
   /* The valid states of a process, according to the Linux kernel.  */

diff --git a/gdb/procfs.c b/gdb/procfs.c
index 81a49002dbbed93ec30e6db35a5c95571d1f9d8e..66a3197b1fc215ea91bb6b0bb0b9d9ca1d9286df 100644 (file)
--- a/gdb/procfs.c
+++ b/gdb/procfs.c
@@ -3848,7 +3848,7 @@ procfs_target::make_corefile_notes (bfd *obfd, int *note_size)
   char psargs[80] = {'\0'};
   procinfo *pi = find_procinfo_or_die (inferior_ptid.pid (), 0);
   char *note_data = NULL;
-  char *inf_args;
+  const char *inf_args;
   struct procfs_corefile_thread_data thread_args;
   enum gdb_signal stop_signal;