i965/screen: Allocate ZEROED BOs for images
authorJason Ekstrand <jason.ekstrand@intel.com>
Thu, 13 Jul 2017 00:06:29 +0000 (17:06 -0700)
committerJason Ekstrand <jason.ekstrand@intel.com>
Mon, 17 Jul 2017 20:48:38 +0000 (13:48 -0700)
Reviewed-by: Chad Versace <chadversary@chromium.org>
src/mesa/drivers/dri/i965/intel_screen.c

index 68026d991be26a122c02018fbd740e86d3b2d884..f137e3ecf97cc99895e3953ddc6d4aac09607032 100644 (file)
@@ -674,9 +674,13 @@ intel_create_image_common(__DRIscreen *dri_screen,
       return NULL;
    }
 
+   /* We request that the bufmgr zero because, if a buffer gets re-used from
+    * the pool, we don't want to leak random garbage from our process to some
+    * other.
+    */
    image->bo = brw_bo_alloc_tiled(screen->bufmgr, "image", surf.size,
                                   isl_tiling_to_i915_tiling(mod_info->tiling),
-                                  surf.row_pitch, 0);
+                                  surf.row_pitch, BO_ALLOC_ZEROED);
    if (image->bo == NULL) {
       free(image);
       return NULL;