re PR libstdc++/49836 ([C++0x] vector<T>::push_back() should not require T to be...
authorPaolo Carlini <paolo.carlini@oracle.com>
Mon, 25 Jul 2011 17:08:48 +0000 (17:08 +0000)
committerPaolo Carlini <paolo@gcc.gnu.org>
Mon, 25 Jul 2011 17:08:48 +0000 (17:08 +0000)
2011-07-25  Paolo Carlini  <paolo.carlini@oracle.com>
    Nathan Ridge  <zeratul976@hotmail.com>

PR libstdc++/49836
* include/bits/stl_vector.h (vector<>::_M_emplace_back_aux):
Declare.
(vector<>::push_back(const value_type&)): Use it.
* include/bits/vector.tcc: Define.
(vector<>::emplace_back(_Args&&...)): Use it.
* testsuite/util/testsuite_tr1.h (CopyConsOnlyType, MoveConsOnlyType):
Add.
* testsuite/23_containers/vector/modifiers/push_back/49836.cc: New.
* testsuite/23_containers/deque/modifiers/push_back/49836.cc:
Likewise.
* testsuite/23_containers/deque/modifiers/push_front/49836.cc:
Likewise.
* testsuite/23_containers/vector/requirements/dr438/assign_neg.cc:
Adjust dg-error line number.
* testsuite/23_containers/vector/requirements/dr438/insert_neg.cc:
Likewise.
* testsuite/23_containers/vector/requirements/dr438/
constructor_1_neg.cc: Likewise.
* testsuite/23_containers/vector/requirements/dr438/
constructor_2_neg.cc: Likewise.

Co-Authored-By: Nathan Ridge <zeratul976@hotmail.com>
From-SVN: r176761

libstdc++-v3/ChangeLog
libstdc++-v3/include/bits/stl_vector.h
libstdc++-v3/include/bits/vector.tcc
libstdc++-v3/testsuite/23_containers/deque/modifiers/push_back/49836.cc [new file with mode: 0644]
libstdc++-v3/testsuite/23_containers/deque/modifiers/push_front/49836.cc [new file with mode: 0644]
libstdc++-v3/testsuite/23_containers/vector/modifiers/push_back/49836.cc [new file with mode: 0644]
libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/assign_neg.cc
libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/constructor_1_neg.cc
libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/constructor_2_neg.cc
libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/insert_neg.cc
libstdc++-v3/testsuite/util/testsuite_tr1.h

index 91301815bad7dc58fab9a27e3444bbd384b7363a..79db713ff5b409351b55bca609568d7c4db6e664 100644 (file)
@@ -1,3 +1,28 @@
+2011-07-25  Paolo Carlini  <paolo.carlini@oracle.com>
+           Nathan Ridge  <zeratul976@hotmail.com>
+
+       PR libstdc++/49836
+       * include/bits/stl_vector.h (vector<>::_M_emplace_back_aux):
+       Declare.
+       (vector<>::push_back(const value_type&)): Use it.
+       * include/bits/vector.tcc: Define.
+       (vector<>::emplace_back(_Args&&...)): Use it.
+       * testsuite/util/testsuite_tr1.h (CopyConsOnlyType, MoveConsOnlyType):
+       Add.
+       * testsuite/23_containers/vector/modifiers/push_back/49836.cc: New.
+       * testsuite/23_containers/deque/modifiers/push_back/49836.cc:
+       Likewise.
+       * testsuite/23_containers/deque/modifiers/push_front/49836.cc:
+       Likewise.
+       * testsuite/23_containers/vector/requirements/dr438/assign_neg.cc:
+       Adjust dg-error line number.
+       * testsuite/23_containers/vector/requirements/dr438/insert_neg.cc:
+       Likewise.
+       * testsuite/23_containers/vector/requirements/dr438/
+       constructor_1_neg.cc: Likewise.
+       * testsuite/23_containers/vector/requirements/dr438/
+       constructor_2_neg.cc: Likewise.
+
 2011-07-24  Paolo Carlini  <paolo.carlini@oracle.com>
 
        * include/bits/hashtable_policy.h (_Prime_rehash_policy::_M_next_bkt,
index 0211033a456fa709773c255d5c55eb2acbac12b8..601459b3eafb0e935cd1fe5c8bff554ce224d0e4 100644 (file)
@@ -902,7 +902,11 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER
            ++this->_M_impl._M_finish;
          }
        else
+#ifdef __GXX_EXPERIMENTAL_CXX0X__
+         _M_emplace_back_aux(__x);
+#else
          _M_insert_aux(end(), __x);
+#endif
       }
 
 #ifdef __GXX_EXPERIMENTAL_CXX0X__
@@ -1303,6 +1307,10 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER
       template<typename... _Args>
         void
         _M_insert_aux(iterator __position, _Args&&... __args);
+
+      template<typename... _Args>
+        void
+        _M_emplace_back_aux(_Args&&... __args);
 #endif
 
       // Called by the latter.
index 85b514b561b00ce2ccacf72cdcfc22d71c43996f..ba98c7cb07ebd1aa7c319e441b3fa0f218507b4b 100644 (file)
@@ -99,7 +99,7 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER
            ++this->_M_impl._M_finish;
          }
        else
-         _M_insert_aux(end(), std::forward<_Args>(__args)...);
+         _M_emplace_back_aux(std::forward<_Args>(__args)...);
       }
 #endif
 
@@ -387,6 +387,50 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER
        }
     }
 
+#ifdef __GXX_EXPERIMENTAL_CXX0X__
+  template<typename _Tp, typename _Alloc>
+    template<typename... _Args>
+      void
+      vector<_Tp, _Alloc>::
+      _M_emplace_back_aux(_Args&&... __args)
+      {
+       const size_type __len =
+         _M_check_len(size_type(1), "vector::_M_emplace_back_aux");
+       pointer __new_start(this->_M_allocate(__len));
+       pointer __new_finish(__new_start);
+       __try
+         {
+           _Alloc_traits::construct(this->_M_impl, __new_start + size(),
+                                    std::forward<_Args>(__args)...);
+           __new_finish = 0;
+
+           __new_finish
+             = std::__uninitialized_move_if_noexcept_a
+             (this->_M_impl._M_start, this->_M_impl._M_finish,
+              __new_start, _M_get_Tp_allocator());
+
+           ++__new_finish;
+         }
+       __catch(...)
+         {
+           if (!__new_finish)
+             _Alloc_traits::destroy(this->_M_impl, __new_start + size());
+           else
+             std::_Destroy(__new_start, __new_finish, _M_get_Tp_allocator());
+           _M_deallocate(__new_start, __len);
+           __throw_exception_again;
+         }
+       std::_Destroy(this->_M_impl._M_start, this->_M_impl._M_finish,
+                     _M_get_Tp_allocator());
+       _M_deallocate(this->_M_impl._M_start,
+                     this->_M_impl._M_end_of_storage
+                     - this->_M_impl._M_start);
+       this->_M_impl._M_start = __new_start;
+       this->_M_impl._M_finish = __new_finish;
+       this->_M_impl._M_end_of_storage = __new_start + __len;
+      }
+#endif
+
   template<typename _Tp, typename _Alloc>
     void
     vector<_Tp, _Alloc>::
diff --git a/libstdc++-v3/testsuite/23_containers/deque/modifiers/push_back/49836.cc b/libstdc++-v3/testsuite/23_containers/deque/modifiers/push_back/49836.cc
new file mode 100644 (file)
index 0000000..290a191
--- /dev/null
@@ -0,0 +1,50 @@
+// { dg-options "-std=gnu++0x" }
+
+// Copyright (C) 2011 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+#include <deque>
+#include <testsuite_hooks.h>
+#include <testsuite_tr1.h>
+
+// libstdc++/49836
+void test01()
+{
+  bool test __attribute__((unused)) = true;
+  using __gnu_test::CopyConsOnlyType;
+  using __gnu_test::MoveConsOnlyType;
+
+  std::deque<CopyConsOnlyType> d1;
+  CopyConsOnlyType t1(1);
+  d1.push_back(t1);
+  d1.push_back(t1);
+  d1.push_back(t1);
+  VERIFY( d1.size() == 3 );
+
+  std::deque<MoveConsOnlyType> d2;
+  MoveConsOnlyType t2(1);
+  d2.push_back(std::move(t2));
+  d2.push_back(std::move(t2));
+  d2.push_back(std::move(t2));
+  VERIFY( d2.size() == 3 );
+}
+
+int main()
+{
+  test01();
+  return 0;
+}
diff --git a/libstdc++-v3/testsuite/23_containers/deque/modifiers/push_front/49836.cc b/libstdc++-v3/testsuite/23_containers/deque/modifiers/push_front/49836.cc
new file mode 100644 (file)
index 0000000..b481aff
--- /dev/null
@@ -0,0 +1,50 @@
+// { dg-options "-std=gnu++0x" }
+
+// Copyright (C) 2011 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+#include <deque>
+#include <testsuite_hooks.h>
+#include <testsuite_tr1.h>
+
+// libstdc++/49836
+void test01()
+{
+  bool test __attribute__((unused)) = true;
+  using __gnu_test::CopyConsOnlyType;
+  using __gnu_test::MoveConsOnlyType;
+
+  std::deque<CopyConsOnlyType> d1;
+  CopyConsOnlyType t1(1);
+  d1.push_front(t1);
+  d1.push_front(t1);
+  d1.push_front(t1);
+  VERIFY( d1.size() == 3 );
+
+  std::deque<MoveConsOnlyType> d2;
+  MoveConsOnlyType t2(1);
+  d2.push_front(std::move(t2));
+  d2.push_front(std::move(t2));
+  d2.push_front(std::move(t2));
+  VERIFY( d2.size() == 3 );
+}
+
+int main()
+{
+  test01();
+  return 0;
+}
diff --git a/libstdc++-v3/testsuite/23_containers/vector/modifiers/push_back/49836.cc b/libstdc++-v3/testsuite/23_containers/vector/modifiers/push_back/49836.cc
new file mode 100644 (file)
index 0000000..0a6426a
--- /dev/null
@@ -0,0 +1,50 @@
+// { dg-options "-std=gnu++0x" }
+
+// Copyright (C) 2011 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+#include <vector>
+#include <testsuite_hooks.h>
+#include <testsuite_tr1.h>
+
+// libstdc++/49836
+void test01()
+{
+  bool test __attribute__((unused)) = true;
+  using __gnu_test::CopyConsOnlyType;
+  using __gnu_test::MoveConsOnlyType;
+
+  std::vector<CopyConsOnlyType> v1;
+  CopyConsOnlyType t1(1);
+  v1.push_back(t1);
+  v1.push_back(t1);
+  v1.push_back(t1);
+  VERIFY( v1.size() == 3 );
+
+  std::vector<MoveConsOnlyType> v2;
+  MoveConsOnlyType t2(1);
+  v2.push_back(std::move(t2));
+  v2.push_back(std::move(t2));
+  v2.push_back(std::move(t2));
+  VERIFY( v2.size() == 3 );
+}
+
+int main()
+{
+  test01();
+  return 0;
+}
index 8ff85455db71c91ce0023de0bc65dee7141ec7dd..55b9096d768b58eba0d1a5ebaf07094cf548fe5a 100644 (file)
@@ -18,7 +18,7 @@
 // <http://www.gnu.org/licenses/>.
 
 // { dg-do compile }
-// { dg-error "no matching" "" { target *-*-* } 1218 }
+// { dg-error "no matching" "" { target *-*-* } 1222 }
 
 #include <vector>
 
index 344f1a68170f39dce62c3c6ba8c3303f4c621a9b..6ea2c6f114512d9edd2590c4bb4d8a6e1ac5aa38 100644 (file)
@@ -18,7 +18,7 @@
 // <http://www.gnu.org/licenses/>.
 
 // { dg-do compile }
-// { dg-error "no matching" "" { target *-*-* } 1148 }
+// { dg-error "no matching" "" { target *-*-* } 1152 }
 
 #include <vector>
 
index 7f3c52e805894776558bb9640b8e182516998aaf..75b5bd6d21822c5fa1c0a829243e4efed2f77d9e 100644 (file)
@@ -18,7 +18,7 @@
 // <http://www.gnu.org/licenses/>.
 
 // { dg-do compile }
-// { dg-error "no matching" "" { target *-*-* } 1148 }
+// { dg-error "no matching" "" { target *-*-* } 1152 }
 
 #include <vector>
 #include <utility>
index c2337c82c657be16ab4b32d12ca7c8b647f2f78e..d93de19d486b6f1243d0369cd88562e9514413d1 100644 (file)
@@ -18,7 +18,7 @@
 // <http://www.gnu.org/licenses/>.
 
 // { dg-do compile }
-// { dg-error "no matching" "" { target *-*-* } 1259 }
+// { dg-error "no matching" "" { target *-*-* } 1263 }
 
 #include <vector>
 
index 842d445389703096a4a7bd01c349cb9fed83d9c0..94207a6e63de17299852738a2d5ff68fbab055b2 100644 (file)
@@ -696,6 +696,24 @@ namespace __gnu_test
       MO& operator=(MO&&) = default;
     };
   }
+
+  struct CopyConsOnlyType
+  {
+    CopyConsOnlyType(int) { }
+    CopyConsOnlyType(CopyConsOnlyType&&) = delete;
+    CopyConsOnlyType(const CopyConsOnlyType&) = default;
+    CopyConsOnlyType& operator=(const CopyConsOnlyType&) = delete;
+    CopyConsOnlyType& operator=(CopyConsOnlyType&&) = delete;
+  };
+
+  struct MoveConsOnlyType
+  {
+    MoveConsOnlyType(int) { }
+    MoveConsOnlyType(const MoveConsOnlyType&) = delete;
+    MoveConsOnlyType(MoveConsOnlyType&&) = default;
+    MoveConsOnlyType& operator=(const MoveConsOnlyType&) = delete;
+    MoveConsOnlyType& operator=(MoveConsOnlyType&&) = delete;
+  };
 #endif
 
 } // namespace __gnu_test