re PR c/86453 (error: type variant differs by TYPE_PACKED in free_lang_data since...

2018-07-12  Richard Biener  <rguenther@suse.de>

	PR c/86453
	* c-attribs.c (handle_packed_attribute): Do not build a variant
	type with TYPE_PACKED, instead ignore the attribute if we may
	not apply to the original type.

	* g++.dg/warn/pr86453.C: New testcase.

From-SVN: r262575

diff --git a/gcc/c-family/ChangeLog b/gcc/c-family/ChangeLog
index a459f0613265c20435a3b9fa5a907b16d27d51d1..115e032e41d7cba2c8076130029858f7943d0d8a 100644 (file)
--- a/gcc/c-family/ChangeLog
+++ b/gcc/c-family/ChangeLog
@@ -1,3 +1,10 @@
+2018-07-12  Richard Biener  <rguenther@suse.de>
+
+       PR c/86453
+       * c-attribs.c (handle_packed_attribute): Do not build a variant
+       type with TYPE_PACKED, instead ignore the attribute if we may
+       not apply to the original type.
+
 2018-07-10  Jakub Jelinek  <jakub@redhat.com>
 
        PR c++/86443

diff --git a/gcc/c-family/c-attribs.c b/gcc/c-family/c-attribs.c
index f91add488bbb5d39365beec2f6b6c37d803c9e4c..8cb87eb81543faee3ec1f8409f38656c48a4373d 100644 (file)
--- a/gcc/c-family/c-attribs.c
+++ b/gcc/c-family/c-attribs.c
@@ -502,8 +502,13 @@ handle_packed_attribute (tree *node, tree name, tree ARG_UNUSED (args),
   if (TYPE_P (*node))
     {
       if (!(flags & (int) ATTR_FLAG_TYPE_IN_PLACE))
-       *node = build_variant_type_copy (*node);
-      TYPE_PACKED (*node) = 1;
+       {
+         warning (OPT_Wattributes,
+                  "%qE attribute ignored for type %qT", name, *node);
+         *no_add_attrs = true;
+       }
+      else
+       TYPE_PACKED (*node) = 1;
     }
   else if (TREE_CODE (*node) == FIELD_DECL)
     {

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 0958a1a57b21cbdf63788bfe9278344da50805db..d68cccf3d0b2a6a35a1144a7c31a94d6e5058163 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2018-07-12  Richard Biener  <rguenther@suse.de>
+
+       PR c/86453
+       * g++.dg/warn/pr86453.C: New testcase.
+
 2018-07-12  Richard Biener  <rguenther@suse.de>
 
        PR middle-end/86479

diff --git a/gcc/testsuite/g++.dg/warn/pr86453.C b/gcc/testsuite/g++.dg/warn/pr86453.C
new file mode 100644 (file)
index 0000000..318f406
--- /dev/null
+++ b/gcc/testsuite/g++.dg/warn/pr86453.C
@@ -0,0 +1,5 @@
+// { dg-do compile }
+// { dg-additional-options "-flto" { target lto } }
+struct X {
+  int *__attribute__((aligned(2), packed)) a; // { dg-warning "attribute ignored" }
+} b;