egl/wayland: plug memory leak in drm_handle_device()
authorEmil Velikov <emil.velikov@collabora.com>
Tue, 27 Nov 2018 11:36:01 +0000 (11:36 +0000)
committerEmil Velikov <emil.l.velikov@gmail.com>
Wed, 28 Nov 2018 16:12:12 +0000 (16:12 +0000)
As we fail to open the node, we leak the node/device name.

v2: Log and then free() (Eric)

Cc: mesa-stable@lists.freedesktop.org
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Eric Engestrom <eric.engestrom@intel.com>
src/egl/drivers/dri2/platform_wayland.c

index b05f5363163c7cc02c21955b9c0954e5120b7699..3254ed9120911936571aa51f060f9baac2da4b91 100644 (file)
@@ -1127,6 +1127,8 @@ drm_handle_device(void *data, struct wl_drm *drm, const char *device)
    if (dri2_dpy->fd == -1) {
       _eglLog(_EGL_WARNING, "wayland-egl: could not open %s (%s)",
               dri2_dpy->device_name, strerror(errno));
+      free(dri2_dpy->device_name);
+      dri2_dpy->device_name = NULL:
       return;
    }