ChangeLog entries for max-completions patch.
authorGary Benson <gbenson@redhat.com>
Sat, 31 Jan 2015 23:24:26 +0000 (15:24 -0800)
committerDoug Evans <xdje42@gmail.com>
Sat, 31 Jan 2015 23:24:26 +0000 (15:24 -0800)
gdb/ChangeLog:

PR cli/9007
PR cli/11920
PR cli/15548
* cli/cli-cmds.c (complete_command): Notify user if max-completions
reached.
* common/common-exceptions.h (enum errors)
<MAX_COMPLETIONS_REACHED_ERROR>: New value.
* completer.h (get_max_completions_reached_message): New declaration.
(max_completions): Likewise.
(completion_tracker_t): New typedef.
(new_completion_tracker): New declaration.
(make_cleanup_free_completion_tracker): Likewise.
(maybe_add_completion_enum): New enum.
(maybe_add_completion): New declaration.
(throw_max_completions_reached_error): Likewise.
* completer.c (max_completions): New global variable.
(new_completion_tracker): New function.
(free_completion_tracker): Likewise.
(make_cleanup_free_completion_tracker): Likewise.
(maybe_add_completions): Likewise.
(throw_max_completions_reached_error): Likewise.
(complete_line): Remove duplicates and limit result to max_completions
entries.
(get_max_completions_reached_message): New function.
(gdb_display_match_list): Handle max_completions.
(_initialize_completer): New declaration and function.
* symtab.c: Include completer.h.
(completion_tracker): New static variable.
(completion_list_add_name): Call maybe_add_completion.
(default_make_symbol_completion_list_break_on_1): Renamed from
default_make_symbol_completion_list_break_on.  Maintain
completion_tracker across calls to completion_list_add_name.
(default_make_symbol_completion_list_break_on): New function.
* top.c (init_main): Set rl_completion_display_matches_hook.
* tui/tui-io.c: Include completer.h.
(tui_old_rl_display_matches_hook): New static global.
(tui_rl_display_match_list): Notify user if max-completions reached.
(tui_setup_io): Save/restore rl_completion_display_matches_hook.
* NEWS (New Options): Mention set/show max-completions.

gdb/doc/ChangeLog:

* gdb.texinfo (Command Completion): Document new
"set/show max-completions" option.

gdb/testsuite/ChangeLog:

* gdb.base/completion.exp: Disable completion limiting for
existing tests.  Add new tests to check completion limiting.
* gdb.linespec/ls-errs.exp: Disable completion limiting.

gdb/ChangeLog
gdb/doc/ChangeLog
gdb/testsuite/ChangeLog

index ad36a702419508c1a3b3bcc43da7125b69f9d847..e88cd57e1a433bcce52a7dfcc883edeb22433929 100644 (file)
@@ -1,3 +1,46 @@
+2015-01-31  Gary Benson <gbenson@redhat.com>
+           Doug Evans  <dje@google.com>
+
+       PR cli/9007
+       PR cli/11920
+       PR cli/15548
+       * cli/cli-cmds.c (complete_command): Notify user if max-completions
+       reached.
+       * common/common-exceptions.h (enum errors)
+       <MAX_COMPLETIONS_REACHED_ERROR>: New value.
+       * completer.h (get_max_completions_reached_message): New declaration.
+       (max_completions): Likewise.
+       (completion_tracker_t): New typedef.
+       (new_completion_tracker): New declaration.
+       (make_cleanup_free_completion_tracker): Likewise.
+       (maybe_add_completion_enum): New enum.
+       (maybe_add_completion): New declaration.
+       (throw_max_completions_reached_error): Likewise.
+       * completer.c (max_completions): New global variable.
+       (new_completion_tracker): New function.
+       (free_completion_tracker): Likewise.
+       (make_cleanup_free_completion_tracker): Likewise.
+       (maybe_add_completions): Likewise.
+       (throw_max_completions_reached_error): Likewise.
+       (complete_line): Remove duplicates and limit result to max_completions
+       entries.
+       (get_max_completions_reached_message): New function.
+       (gdb_display_match_list): Handle max_completions.
+       (_initialize_completer): New declaration and function.
+       * symtab.c: Include completer.h.
+       (completion_tracker): New static variable.
+       (completion_list_add_name): Call maybe_add_completion.
+       (default_make_symbol_completion_list_break_on_1): Renamed from
+       default_make_symbol_completion_list_break_on.  Maintain
+       completion_tracker across calls to completion_list_add_name.
+       (default_make_symbol_completion_list_break_on): New function.
+       * top.c (init_main): Set rl_completion_display_matches_hook.
+       * tui/tui-io.c: Include completer.h.
+       (tui_old_rl_display_matches_hook): New static global.
+       (tui_rl_display_match_list): Notify user if max-completions reached.
+       (tui_setup_io): Save/restore rl_completion_display_matches_hook.
+       * NEWS (New Options): Mention set/show max-completions.
+
 2015-01-31  Gary Benson  <gbenson@redhat.com>
 
        * symtab.c (struct add_name_data) <code>: New field.
index be5f2a6de25a511fe19aaff021968bc038c22ff5..9c12d9af8e918a944408746ec552fdc88d7837fe 100644 (file)
@@ -1,3 +1,9 @@
+2015-01-31  Gary Benson <gbenson@redhat.com>
+           Doug Evans  <dje@google.com>
+
+       * gdb.texinfo (Command Completion): Document new
+       "set/show max-completions" option.
+
 2015-01-31  Doug Evans  <xdje42@gmail.com>
 
        * gdb.texinfo (Symbols): Document new commands
index c5cff1867e3380de36226c4ac152834f7de679f9..08c951cf64cdcbbad90f82085a469e650c5ba37c 100644 (file)
@@ -1,3 +1,9 @@
+2015-01-31  Gary Benson <gbenson@redhat.com>
+
+       * gdb.base/completion.exp: Disable completion limiting for
+       existing tests.  Add new tests to check completion limiting.
+       * gdb.linespec/ls-errs.exp: Disable completion limiting.
+
 2015-01-31  Doug Evans  <xdje42@gmail.com>
 
        * gdb.ada/dyn_arrayidx.exp: Add additional_flags=-gnat12.