package/lynx: fix build with libidn
authorVadim Kochan <vadim4j@gmail.com>
Tue, 14 May 2019 20:25:47 +0000 (23:25 +0300)
committerPeter Korsgaard <peter@korsgaard.com>
Wed, 15 May 2019 09:53:42 +0000 (11:53 +0200)
In case of BR2_STATIC_LIBS=y the linking with libidn fails because
linker can't resolve libiconv symbols needed by libidn. Fix it by
required LIBS for libidn generated by pkg-conf.

The issue can be reproduced with the following defconfig:

BR2_x86_i686=y
BR2_STATIC_LIBS=y
BR2_PACKAGE_LIBICONV=y
BR2_PACKAGE_LIBIDN=y
BR2_PACKAGE_LYNX=y

Fixes:
http://autobuild.buildroot.net/results/23a421e15c32b17ff2f69f183a2e8620ecb93316/

Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
package/lynx/lynx.mk

index 3ac5b4cabf62d589cadd73935aa6ff775c119675..b6cc1b2b9160d6d01ad8c6fd1b0b953b9c04bcc9 100644 (file)
@@ -23,7 +23,7 @@ endif
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
 LYNX_DEPENDENCIES += host-pkgconf openssl
 LYNX_CONF_OPTS += --with-ssl=$(STAGING_DIR)/usr
-LYNX_CONF_ENV = LIBS=`$(PKG_CONFIG_HOST_BINARY) --libs openssl`
+LYNX_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs openssl`
 else ifeq ($(BR2_PACKAGE_GNUTLS),y)
 LYNX_DEPENDENCIES += gnutls
 LYNX_CONF_OPTS += --with-gnutls
@@ -36,4 +36,11 @@ else
 LYNX_CONF_OPTS += --without-zlib
 endif
 
+ifeq ($(BR2_PACKAGE_LIBIDN),y)
+LYNX_DEPENDENCIES += libidn
+LYNX_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs libidn`
+endif
+
+LYNX_CONF_ENV = LIBS="$(LYNX_LIBS)"
+
 $(eval $(autotools-package))