re PR ipa/66223 (Diagnostic of pure virtual function call broken, including __cxa_pur...

	PR ipa/66223
	* ipa-devirt.c (maybe_record_node): Do not optimize cxa_pure_virtual
	calls when sanitizing.
	(possible_polymorphic_call_target_p)" FIx formating.
	* g++.dg/ipa/devirt-51.C: New testcase.

From-SVN: r234719

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index b478b0f2832aee12b9caa4369b84030d94b459ef..d9ad89c3dd6669945e7d95619f5448df73181053 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,10 @@
+2016-04-04  Jan Hubicka  <hubicka@ucw.cz>
+
+       PR ipa/66223
+       * ipa-devirt.c (maybe_record_node): Do not optimize cxa_pure_virtual
+       calls when sanitizing.
+       (possible_polymorphic_call_target_p)" FIx formating.
+
 2016-04-04  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>
            Jakub Jelinek <jakub@redhat.com>
 

diff --git a/gcc/ipa-devirt.c b/gcc/ipa-devirt.c
index 069495105bfb368f4d87c7369fb09cccf7d55784..22ece9f76afcd4a305c91f1c046f6a27bba28fce 100644 (file)
--- a/gcc/ipa-devirt.c
+++ b/gcc/ipa-devirt.c
@@ -2438,10 +2438,14 @@ maybe_record_node (vec <cgraph_node *> &nodes,
     {
       gcc_assert (!target_node->global.inlined_to);
       gcc_assert (target_node->real_symbol_p ());
+      /* When sanitizing, do not asume that cxa_pure_virutal is not called
+        by valid program.  */
+      if (flag_sanitize & SANITIZE_UNDEFINED)
+       ;
       /* Only add pure virtual if it is the only possible target.  This way
         we will preserve the diagnostics about pure virtual called in many
         cases without disabling optimization in other.  */
-      if (pure_virtual)
+      else if (pure_virtual)
        {
          if (nodes.length ())
            return;
@@ -3374,8 +3378,7 @@ possible_polymorphic_call_target_p (tree otr_type,
   bool final;
 
   if (TREE_CODE (TREE_TYPE (n->decl)) == FUNCTION_TYPE
-      && ((fcode = DECL_FUNCTION_CODE (n->decl))
-         == BUILT_IN_UNREACHABLE
+      && ((fcode = DECL_FUNCTION_CODE (n->decl)) == BUILT_IN_UNREACHABLE
           || fcode == BUILT_IN_TRAP))
     return true;
 

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index c9b020524d61bcd84c9c75c11959b138c607b239..168b769b859a02bc17cc98d9a15b590960c5ee9a 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2016-04-04  Jan Hubicka  <hubicka@ucw.cz>
+
+       PR ipa/66223
+       * g++.dg/ipa/devirt-51.C: New testcase.
+
 2016-04-04  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>
            Jakub Jelinek <jakub@redhat.com>
 

diff --git a/gcc/testsuite/g++.dg/ipa/devirt-51.C b/gcc/testsuite/g++.dg/ipa/devirt-51.C
new file mode 100644 (file)
index 0000000..fadf9e2
--- /dev/null
+++ b/gcc/testsuite/g++.dg/ipa/devirt-51.C
@@ -0,0 +1,32 @@
+/* Be sure we do not optimize the virtual call into call of the only non-virtual
+   variant.  Either keeping virtual call or optimizing to cxa_pure_virtual
+   is fine.  */
+/* { dg-do compile } */
+/* { dg-options "-O2 -fsanitize=undefined -fdump-tree-optimized"  } */
+namespace {
+  struct B {
+        B* self;
+        B() : self( this ) { self->f(); }
+       void E(void);
+        virtual void f() = 0;
+    };
+
+    struct D : B
+    {
+        void f() {}
+    };
+}
+
+struct D e;
+
+__attribute__ ((used))
+void B::E(void)
+  {
+    this->f();
+}
+
+    int main()
+    {
+        D d;
+    }
+/* { dg-final { scan-tree-dump "cxa_pure_virtual" "optimized"  } } */