bfd: avoid infinite loop when static linking XCOFF

git commit b95a0a3177bc changed a "return FALSE" to "continue", and
missed updating the while loop iterator.

	* xcofflink.c (xcoff_link_check_ar_symbols): Update esym earlier.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 28c5791282c5cf5821555bca4f8f5748bef608c6..1603be8e954014d74299ee178d524eccf8da2933 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,7 @@
+2021-04-13  Clément Chigot  <clement.chigot@atos.net>
+
+       * xcofflink.c (xcoff_link_check_ar_symbols): Update esym earlier.
+
 2021-04-13  Nelson Chu  <nelson.chu@sifive.com>
 
        * elfnn-riscv.c (riscv_version_mismatch): Do not report the warning

diff --git a/bfd/xcofflink.c b/bfd/xcofflink.c
index 84048620b8e77c01b697ff3c730b1b457f80c81b..f0e0fe7aafc9e3991869b618289f838d91a1be4d 100644 (file)
--- a/bfd/xcofflink.c
+++ b/bfd/xcofflink.c
@@ -2349,6 +2349,7 @@ xcoff_link_check_ar_symbols (bfd *abfd,
       struct internal_syment sym;
 
       bfd_coff_swap_sym_in (abfd, (void *) esym, (void *) &sym);
+      esym += (sym.n_numaux + 1) * symesz;
 
       if (EXTERN_SYM_P (sym.n_sclass) && sym.n_scnum != N_UNDEF)
        {
@@ -2382,8 +2383,6 @@ xcoff_link_check_ar_symbols (bfd *abfd,
              return true;
            }
        }
-
-      esym += (sym.n_numaux + 1) * symesz;
     }
 
   /* We do not need this object file.  */