PR ld/12549

	* elf-bfd.h (_bfd_elf_strtab_clear_refs): Delete.
	(_bfd_elf_strtab_clear_all_refs): Declare.
	(_bfd_elf_strtab_resize): Declare.
	* elf-strtab.c (_bfd_elf_strtab_clear_refs): Delete.
	(_bfd_elf_strtab_clear_all_refs): New function.
	(_bfd_elf_strtab_resize): Likewise.
	* elflink.c (elf_link_add_object_symbols): Use _bfd_elf_strtab_resize.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 5411140ed56e37fab80eea617909b146ca322a77..76558b3d60f72484353c3f5021d0d098d21dace9 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,14 @@
+2013-02-18  Alan Modra  <amodra@gmail.com>
+
+       PR ld/12549
+       * elf-bfd.h (_bfd_elf_strtab_clear_refs): Delete.
+       (_bfd_elf_strtab_clear_all_refs): Declare.
+       (_bfd_elf_strtab_resize): Declare.
+       * elf-strtab.c (_bfd_elf_strtab_clear_refs): Delete.
+       (_bfd_elf_strtab_clear_all_refs): New function.
+       (_bfd_elf_strtab_resize): Likewise.
+       * elflink.c (elf_link_add_object_symbols): Use _bfd_elf_strtab_resize.
+
 2013-02-18  Alan Modra  <amodra@gmail.com>
 
        * elf-bfd.h (struct elf_obj_tdata): Move find_line_info, local_stubs,

diff --git a/bfd/elf-bfd.h b/bfd/elf-bfd.h
index d36c2875ec3f70fc90209ed40190129878c81f97..c8d2957e2d488b44d1b6343dd0bdfcb54e61fbab 100644 (file)
--- a/bfd/elf-bfd.h
+++ b/bfd/elf-bfd.h
@@ -1927,10 +1927,10 @@ extern void _bfd_elf_strtab_delref
   (struct elf_strtab_hash *, bfd_size_type);
 extern unsigned int _bfd_elf_strtab_refcount
   (struct elf_strtab_hash *, bfd_size_type);
-extern void _bfd_elf_strtab_clear_refs
+extern void _bfd_elf_strtab_clear_all_refs
+  (struct elf_strtab_hash *tab);
+extern void _bfd_elf_strtab_restore_size
   (struct elf_strtab_hash *, bfd_size_type);
-#define _bfd_elf_strtab_clear_all_refs(tab) \
-  do { _bfd_elf_strtab_clear_refs (tab, 1); } while (0)
 extern bfd_size_type _bfd_elf_strtab_size
   (struct elf_strtab_hash *);
 extern bfd_size_type _bfd_elf_strtab_offset

diff --git a/bfd/elf-strtab.c b/bfd/elf-strtab.c
index 45743f608a2d8f9d2db1d63eb2ecae8583942f14..61cedaedcc34d3a5c7c7639545a388ede9068de0 100644 (file)
--- a/bfd/elf-strtab.c
+++ b/bfd/elf-strtab.c
@@ -208,10 +208,32 @@ _bfd_elf_strtab_refcount (struct elf_strtab_hash *tab, bfd_size_type idx)
 }
 
 void
-_bfd_elf_strtab_clear_refs (struct elf_strtab_hash *tab, bfd_size_type idx)
+_bfd_elf_strtab_clear_all_refs (struct elf_strtab_hash *tab)
 {
-  while (idx < tab->size)
-    tab->array[idx++]->refcount = 0;
+  bfd_size_type idx;
+
+  for (idx = 1; idx < tab->size; idx++)
+    tab->array[idx]->refcount = 0;
+}
+
+/* Downsizes strtab.  Entries from IDX up to the current size are
+   removed from the array.  */
+void
+_bfd_elf_strtab_restore_size (struct elf_strtab_hash *tab, bfd_size_type idx)
+{
+  bfd_size_type curr_size = tab->size;
+
+  BFD_ASSERT (tab->sec_size == 0);
+  BFD_ASSERT (idx <= curr_size);
+  tab->size = idx;
+  for (; idx < curr_size; ++idx)
+    {
+      /* We don't remove entries from the hash table, just set their
+        REFCOUNT to zero.  Setting LEN zero will result in the size
+        growing if the entry is added again.  See _bfd_elf_strtab_add.  */
+      tab->array[idx]->refcount = 0;
+      tab->array[idx]->len = 0;
+    }
 }
 
 bfd_size_type

diff --git a/bfd/elflink.c b/bfd/elflink.c
index 617c505ffb0abff93893bab5f633a3ab78f395d3..b652becf8c8238bf43708539aa7fa1cf49727a1e 100644 (file)
--- a/bfd/elflink.c
+++ b/bfd/elflink.c
@@ -4554,7 +4554,7 @@ error_free_dyn:
       memcpy (sym_hash, old_hash, hashsize);
       htab->root.undefs = old_undefs;
       htab->root.undefs_tail = old_undefs_tail;
-      _bfd_elf_strtab_clear_refs (htab->dynstr, old_dynstr_size);
+      _bfd_elf_strtab_restore_size (htab->dynstr, old_dynstr_size);
       for (i = 0; i < htab->root.table.size; i++)
        {
          struct bfd_hash_entry *p;