re PR tree-optimization/78496 (Missed opportunities for jump threading)
authorJeff Law <law@redhat.com>
Mon, 4 Dec 2017 16:14:24 +0000 (09:14 -0700)
committerJeff Law <law@gcc.gnu.org>
Mon, 4 Dec 2017 16:14:24 +0000 (09:14 -0700)
PR tree-optimizatin/78496
* gimple-ssa-evrp-analyze.h
(evrp_range_analyzer::get_vr_values): Simplify.
* gimple-ssa-evrp-analyze.c: Corresponding changes.
* tree-ssa-dom.c: Include alloc-pool.h, tree-vrp.h, vr-values.h
and gimple-ssa-evrp-analyze.h.
(dom_opt_dom_walker class): Add evrp_range_analyzer member.
(simplify_stmt_for_jump_threading): Copy a blob of code from
tree-vrp.c to use ranges to simplify statements.
(dom_opt_dom_walker::before_dom_children): Call
evrp_range_analyzer::{enter,record_ranges_from_stmt} methods.
(dom_opt_dom_walker::after_dom_children): Similarly for
evrp_range_analyzer::leave.
(dom_opt_dom_walker::optimize_stmt): Use EVRP ranges to optimize
conditionals.

PR tree-optimization/78496
* gcc.dg/builtin-unreachable-6.c: Disable DOM.
* gcc.dg/builtin-unreachable-6a.c: New test.
* gcc.dg/tree-ssa/20030922-1.c: No longer XFAIL.
* gcc.dg/ssa-dom-branch-1.c: Tweak expected output.

From-SVN: r255387

gcc/ChangeLog
gcc/gimple-ssa-evrp-analyze.h
gcc/gimple-ssa-evrp.c
gcc/testsuite/ChangeLog
gcc/testsuite/gcc.dg/builtin-unreachable-6.c
gcc/testsuite/gcc.dg/builtin-unreachable-6a.c [new file with mode: 0644]
gcc/testsuite/gcc.dg/tree-ssa/20030922-2.c
gcc/testsuite/gcc.dg/tree-ssa/ssa-dom-branch-1.c
gcc/tree-ssa-dom.c

index e6523a3f16534f29469773730ff52ab989a48a4f..97c64c70560341164f060c849f68ca3af1458da7 100644 (file)
@@ -1,5 +1,21 @@
 2017-12-04  Jeff Law  <law@redhat.com>
 
+       PR tree-optimizatin/78496
+       * gimple-ssa-evrp-analyze.h
+       (evrp_range_analyzer::get_vr_values): Simplify.
+       * gimple-ssa-evrp-analyze.c: Corresponding changes.
+       * tree-ssa-dom.c: Include alloc-pool.h, tree-vrp.h, vr-values.h
+       and gimple-ssa-evrp-analyze.h.
+       (dom_opt_dom_walker class): Add evrp_range_analyzer member.
+       (simplify_stmt_for_jump_threading): Copy a blob of code from
+       tree-vrp.c to use ranges to simplify statements.
+       (dom_opt_dom_walker::before_dom_children): Call
+       evrp_range_analyzer::{enter,record_ranges_from_stmt} methods.
+       (dom_opt_dom_walker::after_dom_children): Similarly for
+       evrp_range_analyzer::leave.
+       (dom_opt_dom_walker::optimize_stmt): Use EVRP ranges to optimize
+       conditionals.
+
        * gimple-ssa-evrp-analyze.c
        (evrp_range_analyzer::extract_range_from_stmt):  Always use
        vr_values::update_value_range so preexisting range info is
index 6216a9092319263e4bfbb7755adf2fc653fe78a9..4783e6f772eb1f879b11a508ad665241b6bd726b 100644 (file)
@@ -51,13 +51,7 @@ class evrp_range_analyzer
      true, then we are transferring ownership.  Else we keep ownership.
 
      This should be converted to a unique_ptr.  */
-  class vr_values *get_vr_values (bool transfer)
-    {
-      class vr_values *x = vr_values;
-      if (transfer)
-       vr_values = NULL;
-      return x;
-    }
+  class vr_values *get_vr_values (void) { return vr_values; }
 
  private:
   DISABLE_COPY_AND_ASSIGN (evrp_range_analyzer);
index a554cf9e834ab5e283f427df09b0ddb6518c8da1..609ce38f2182d38e7fea1135eb3f347b1876378c 100644 (file)
@@ -68,7 +68,7 @@ class evrp_dom_walker : public dom_walker
 public:
   evrp_dom_walker ()
     : dom_walker (CDI_DOMINATORS),
-      evrp_folder (evrp_range_analyzer.get_vr_values (false))
+      evrp_folder (evrp_range_analyzer.get_vr_values ())
     {
       need_eh_cleanup = BITMAP_ALLOC (NULL);
     }
index 4d02ff726fbc590c45c8fe4061d6a856a32b4ca4..16eee3d024da9975e256917d5768b7d065fb3cd3 100644 (file)
@@ -1,3 +1,11 @@
+2017-12-04  Jeff Law  <law@redhat.com>
+
+       PR tree-optimization/78496
+       * gcc.dg/builtin-unreachable-6.c: Disable DOM.
+       * gcc.dg/builtin-unreachable-6a.c: New test.
+       * gcc.dg/tree-ssa/20030922-1.c: No longer XFAIL.
+       * gcc.dg/ssa-dom-branch-1.c: Tweak expected output.
+
 2017-12-04  Richard Biener  <rguenther@suse.de>
 
        PR tree-optimization/83255
index 2f8ca3695463fc6780d51c7f8f8db98e04a741dd..1915dd13f42f13f6415447a882d9cc5840fe0a1e 100644 (file)
@@ -1,5 +1,5 @@
 /* { dg-do compile } */
-/* { dg-options "-O2 -fdump-tree-fab1" } */
+/* { dg-options "-O2 -fdump-tree-fab1 -fno-tree-dominator-opts" } */
 
 void
 foo (int b, int c)
diff --git a/gcc/testsuite/gcc.dg/builtin-unreachable-6a.c b/gcc/testsuite/gcc.dg/builtin-unreachable-6a.c
new file mode 100644 (file)
index 0000000..f527f2e
--- /dev/null
@@ -0,0 +1,7 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-fab1" } */
+
+#include "builtin-unreachable-6.c"
+
+/* { dg-final { scan-tree-dump-times "lab:" 1 "fab1" } } */
+/* { dg-final { scan-tree-dump-not "__builtin_unreachable" "fab1" } } */
index 172f203cf8e4da0959b990e4d94c95a302ad53d7..16c79da9521cec88426d1e48958c53a219307ce1 100644 (file)
@@ -20,6 +20,4 @@ rgn_rank (rtx insn1, rtx insn2)
 }
 
 /* There should be two IF conditionals.  */
-/* We no longer record the conditional equivalence by design, thus we
-   are unable to simplify the 3rd conditional at compile time.  */
-/* { dg-final { scan-tree-dump-times "if " 2 "dom2" { xfail *-*-* } } } */
+/* { dg-final { scan-tree-dump-times "if " 2 "dom2" } } */
index 3c15296dfeb21e42135637ad043546205a35077b..fae5bdef8186eb152ca8249b0f1a9d434e176d78 100644 (file)
@@ -19,9 +19,10 @@ try_combine (rtx i1, rtx newpat)
   else if (i1 && foo ());
 }
 
-/* There should be two tests against i1.  One from the hash table
-   dumps, one in the code itself.  */
-/* { dg-final { scan-tree-dump-times "if .i1_" 2 "dom2"} } */
+/* There should be four tests against i1.  One from the hash table
+   dumps, one from the EVRP analyzer one from EVRP evaluation and one
+   in the code itself.  */
+/* { dg-final { scan-tree-dump-times "if .i1_" 4 "dom2"} } */
 
 /* There should be no actual jump threads realized by DOM.  The
    legitimize jump threads are handled in VRP and those discovered
index 916d66134c38be50ed956fe7815d4b964697e87e..59a7d87898e185587acf9cf98148161367eca6fc 100644 (file)
@@ -46,6 +46,10 @@ along with GCC; see the file COPYING3.  If not see
 #include "gimplify.h"
 #include "tree-cfgcleanup.h"
 #include "dbgcnt.h"
+#include "alloc-pool.h"
+#include "tree-vrp.h"
+#include "vr-values.h"
+#include "gimple-ssa-evrp-analyze.h"
 
 /* This file implements optimizations on the dominator tree.  */
 
@@ -584,6 +588,9 @@ private:
   class const_and_copies *m_const_and_copies;
   class avail_exprs_stack *m_avail_exprs_stack;
 
+  /* VRP data.  */
+  class evrp_range_analyzer evrp_range_analyzer;
+
   /* Dummy condition to avoid creating lots of throw away statements.  */
   gcond *m_dummy_cond;
 
@@ -835,6 +842,9 @@ make_pass_dominator (gcc::context *ctxt)
   return new pass_dominator (ctxt);
 }
 
+/* A hack until we remove threading from tree-vrp.c and bring the
+   simplification routine into the dom_opt_dom_walker class.  */
+static class vr_values *x_vr_values;
 
 /* A trivial wrapper so that we can present the generic jump
    threading code with a simple API for simplifying statements.  */
@@ -844,7 +854,95 @@ simplify_stmt_for_jump_threading (gimple *stmt,
                                  class avail_exprs_stack *avail_exprs_stack,
                                  basic_block bb ATTRIBUTE_UNUSED)
 {
-  return avail_exprs_stack->lookup_avail_expr (stmt, false, true);
+  /* First query our hash table to see if the the expression is available
+     there.  A non-NULL return value will be either a constant or another
+     SSA_NAME.  */
+  tree cached_lhs =  avail_exprs_stack->lookup_avail_expr (stmt, false, true);
+  if (cached_lhs)
+    return cached_lhs;
+
+  /* If the hash table query failed, query VRP information.  This is
+     essentially the same as tree-vrp's simplification routine.  The
+     copy in tree-vrp is scheduled for removal in gcc-9.  */
+  if (gcond *cond_stmt = dyn_cast <gcond *> (stmt))
+    {
+      cached_lhs
+       = x_vr_values->vrp_evaluate_conditional (gimple_cond_code (cond_stmt),
+                                                gimple_cond_lhs (cond_stmt),
+                                                gimple_cond_rhs (cond_stmt),
+                                                within_stmt);
+      return cached_lhs;
+    }
+
+  if (gswitch *switch_stmt = dyn_cast <gswitch *> (stmt))
+    {
+      tree op = gimple_switch_index (switch_stmt);
+      if (TREE_CODE (op) != SSA_NAME)
+       return NULL_TREE;
+
+      value_range *vr = x_vr_values->get_value_range (op);
+      if ((vr->type != VR_RANGE && vr->type != VR_ANTI_RANGE)
+         || symbolic_range_p (vr))
+       return NULL_TREE;
+
+      if (vr->type == VR_RANGE)
+       {
+         size_t i, j;
+
+         find_case_label_range (switch_stmt, vr->min, vr->max, &i, &j);
+
+         if (i == j)
+           {
+             tree label = gimple_switch_label (switch_stmt, i);
+
+             if (CASE_HIGH (label) != NULL_TREE
+                 ? (tree_int_cst_compare (CASE_LOW (label), vr->min) <= 0
+                    && tree_int_cst_compare (CASE_HIGH (label), vr->max) >= 0)
+                 : (tree_int_cst_equal (CASE_LOW (label), vr->min)
+                    && tree_int_cst_equal (vr->min, vr->max)))
+               return label;
+
+             if (i > j)
+               return gimple_switch_label (switch_stmt, 0);
+           }
+       }
+
+      if (vr->type == VR_ANTI_RANGE)
+          {
+            unsigned n = gimple_switch_num_labels (switch_stmt);
+            tree min_label = gimple_switch_label (switch_stmt, 1);
+            tree max_label = gimple_switch_label (switch_stmt, n - 1);
+
+            /* The default label will be taken only if the anti-range of the
+               operand is entirely outside the bounds of all the (non-default)
+               case labels.  */
+            if (tree_int_cst_compare (vr->min, CASE_LOW (min_label)) <= 0
+                && (CASE_HIGH (max_label) != NULL_TREE
+                    ? tree_int_cst_compare (vr->max, CASE_HIGH (max_label)) >= 0
+                    : tree_int_cst_compare (vr->max, CASE_LOW (max_label)) >= 0))
+            return gimple_switch_label (switch_stmt, 0);
+          }
+       return NULL_TREE;
+    }
+
+  if (gassign *assign_stmt = dyn_cast <gassign *> (stmt))
+    {
+      tree lhs = gimple_assign_lhs (assign_stmt);
+      if (TREE_CODE (lhs) == SSA_NAME
+         && (INTEGRAL_TYPE_P (TREE_TYPE (lhs))
+             || POINTER_TYPE_P (TREE_TYPE (lhs)))
+         && stmt_interesting_for_vrp (stmt))
+       {
+         edge dummy_e;
+         tree dummy_tree;
+         value_range new_vr = VR_INITIALIZER;
+         x_vr_values->extract_range_from_stmt (stmt, &dummy_e,
+                                             &dummy_tree, &new_vr);
+         if (range_int_cst_singleton_p (&new_vr))
+           return new_vr.min;
+       }
+    }
+  return NULL;
 }
 
 /* Valueize hook for gimple_fold_stmt_to_constant_1.  */
@@ -1310,6 +1408,8 @@ dom_opt_dom_walker::before_dom_children (basic_block bb)
   if (dump_file && (dump_flags & TDF_DETAILS))
     fprintf (dump_file, "\n\nOptimizing block #%d\n\n", bb->index);
 
+  evrp_range_analyzer.enter (bb);
+
   /* Push a marker on the stacks of local information so that we know how
      far to unwind when we finalize this block.  */
   m_avail_exprs_stack->push_marker ();
@@ -1332,7 +1432,10 @@ dom_opt_dom_walker::before_dom_children (basic_block bb)
 
   edge taken_edge = NULL;
   for (gsi = gsi_start_bb (bb); !gsi_end_p (gsi); gsi_next (&gsi))
-    taken_edge = this->optimize_stmt (bb, gsi);
+    {
+      evrp_range_analyzer.record_ranges_from_stmt (gsi_stmt (gsi));
+      taken_edge = this->optimize_stmt (bb, gsi);
+    }
 
   /* Now prepare to process dominated blocks.  */
   record_edge_info (bb);
@@ -1350,13 +1453,16 @@ dom_opt_dom_walker::before_dom_children (basic_block bb)
 void
 dom_opt_dom_walker::after_dom_children (basic_block bb)
 {
+  x_vr_values = evrp_range_analyzer.get_vr_values ();
   thread_outgoing_edges (bb, m_dummy_cond, m_const_and_copies,
                         m_avail_exprs_stack,
                         simplify_stmt_for_jump_threading);
+  x_vr_values = NULL;
 
   /* These remove expressions local to BB from the tables.  */
   m_avail_exprs_stack->pop_to_marker ();
   m_const_and_copies->pop_to_marker ();
+  evrp_range_analyzer.leave (bb);
 }
 
 /* Search for redundant computations in STMT.  If any are found, then
@@ -1902,6 +2008,31 @@ dom_opt_dom_walker::optimize_stmt (basic_block bb, gimple_stmt_iterator si)
                                                 integer_zero_node));
              gimple_set_modified (stmt, true);
            }
+         else if (TREE_CODE (lhs) == SSA_NAME)
+           {
+             /* Exploiting EVRP data is not yet fully integrated into DOM
+                but we need to do something for this case to avoid regressing
+                udr4.f90 and new1.C which have unexecutable blocks with
+                undefined behavior that get diagnosed if they're left in the
+                IL because we've attached range information to new
+                SSA_NAMES.  */
+             edge taken_edge = NULL;
+             evrp_range_analyzer.vrp_visit_cond_stmt (as_a <gcond *> (stmt),
+                                                      &taken_edge);
+             if (taken_edge)
+               {
+                 if (taken_edge->flags & EDGE_TRUE_VALUE)
+                   gimple_cond_make_true (as_a <gcond *> (stmt));
+                 else if (taken_edge->flags & EDGE_FALSE_VALUE)
+                   gimple_cond_make_false (as_a <gcond *> (stmt));
+                 else
+                   gcc_unreachable ();
+                 gimple_set_modified (stmt, true);
+                 update_stmt (stmt);
+                 cfg_altered = true;
+                 return taken_edge;
+               }
+           }
        }
 
       update_stmt_if_modified (stmt);