StringBuffer.java (insert(int,char[])): Avoid NullPointerException so proper check...

	* java/lang/StringBuffer.java (insert(int,char[])): Avoid
	NullPointerException so proper check of offset can be done.

From-SVN: r38132

diff --git a/libjava/ChangeLog b/libjava/ChangeLog
index 91f20e77135e4285de10255d4c4b53f785d7427e..9d5f97ebe1ef7467beed736bb8e8353ff42768c4 100644 (file)
--- a/libjava/ChangeLog
+++ b/libjava/ChangeLog
@@ -1,3 +1,8 @@
+2000-12-08  Warren Levy  <warrenl@redhat.com>
+
+       * java/lang/StringBuffer.java (insert(int,char[])): Avoid
+       NullPointerException so proper check of offset can be done.
+
 2000-12-08  Warren Levy  <warrenl@redhat.com>
 
        * java/io/FileInputStream.java (close): Check if the fd is valid.

diff --git a/libjava/java/lang/StringBuffer.java b/libjava/java/lang/StringBuffer.java
index 6e00fa7eba0c335735e1475391368f653c834cb7..0455ca66c245a7221011d1499e7f6f950613691e 100644 (file)
--- a/libjava/java/lang/StringBuffer.java
+++ b/libjava/java/lang/StringBuffer.java
@@ -454,7 +454,9 @@ public final class StringBuffer implements Serializable
    */
   public StringBuffer insert (int offset, char[] data)
   {
-    return insert (offset, data, 0, data.length);
+    // One could check if offset is invalid here instead of making sure that
+    // data isn't null before dereferencing, but this works just as well.
+    return insert (offset, data, 0, data == null ? 0 : data.length);
   }
 
   /** Insert the <code>char[]</code> argument into this