+2006-02-12 Gabriel Dos Reis <gdr@integrable-solutions.net>
+
+ * doc/invoke.texi (-Write-strings): Document that it is enabled by
+ default.
+ * c.opt (-Wwrite-strings): Declare variable warn_write_strings.
+ Clarify documentation.
+ * c-common.h (warn_write_strings): Remove.
+ * c-common.c (warn_write_strings): Likewise.
+ * c-opts.c (c_common_init_options): Enable -Wwrite-strings by
+ default for C++.
+
2006-02-12 Roger Sayle <roger@eyesopen.com>
PR middle-end/25724
int flag_signed_bitfields = 1;
-/* Nonzero means warn about deprecated conversion from string constant to
- `char *'. */
-
-int warn_write_strings;
-
/* Warn about #pragma directives that are not recognized. */
int warn_unknown_pragmas; /* Tri state variable. */
extern int flag_signed_bitfields;
-/* Nonzero means warn about deprecated conversion from string constant to
- `char *'. */
-
-extern int warn_write_strings;
-
/* Warn about #pragma directives that are not recognized. */
extern int warn_unknown_pragmas; /* Tri state variable. */
flag_exceptions = c_dialect_cxx ();
warn_pointer_arith = c_dialect_cxx ();
+ warn_write_strings = c_dialect_cxx();
deferred_opts = XNEWVEC (struct deferred_opt, argc);
Do not warn about using variadic macros when -pedantic
Wwrite-strings
-C ObjC C++ ObjC++
-Give strings the type \"array of char\"
+C ObjC C++ ObjC++ Var(warn_write_strings)
+In C++, nonzero means warn about deprecated conversion from string literals to `char *'. In C, similar warning, except that the conversion is of course not deprecated by the ISO C standard.
Wpointer-sign
C ObjC Var(warn_pointer_sign) Init(-1)
char[@var{length}]} so that
copying the address of one into a non-@code{const} @code{char *}
pointer will get a warning; when compiling C++, warn about the
-deprecated conversion from string constants to @code{char *}.
+deprecated conversion from string literals to @code{char *}. This
+warning, by default, is enabled for C++ programs.
These warnings will help you find at
compile time code that can try to write into a string constant, but
only if you have been very careful about using @code{const} in
+2006-02-12 Gabriel Dos Reis <gdr@integrable-solutions.net>
+
+ * g++.dg/warn/no-write-strings.C: New test.
+ * g++.dg/warn/write-strings.C: Likewise.
+ * g++.dg/warn/write-strings-default.C: Likewise.
+
2006-02-12 Erik Edelmann <eedelman@gcc.gnu.org>
PR fortran/25806
--- /dev/null
+// { dg-do compile }
+// { dg-options -Wno-write-strings }
+
+int main()
+{
+ char* p = "Asgaard";
+}
--- /dev/null
+// { dg-do compile }
+// Test the default for -Wwrite-strings
+
+int main()
+{
+ char* p = "Asgaard"; // { dg-warning "warning:.*deprecated.*" }
+}
--- /dev/null
+// { dg-do compile }
+// { dg-options -Wwrite-strings }
+
+int main()
+{
+ char* p = "Asgaard"; // { dg-warning "warning:.*deprecated.*" }
+}