turnip: remove unused descriptor state dirty
authorAlejandro Piñeiro <apinheiro@igalia.com>
Wed, 29 Jan 2020 13:20:19 +0000 (14:20 +0100)
committerMarge Bot <eric+marge@anholt.net>
Wed, 29 Jan 2020 20:52:52 +0000 (20:52 +0000)
It was only used to be initialized to zero. Not even updated as
descriptor sets are bind.

As far as I understand, setting the bit TU_CMD_DIRTY_DESCRIPTOR_SET on
tu_cmd_state.dirty is used instead.

Reviewed-by: Jonathan Marek <jonathan@marek.ca>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3624>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3624>

src/freedreno/vulkan/tu_cmd_buffer.c
src/freedreno/vulkan/tu_private.h

index a11cab52945e7ca4e1833b26a4a88ee19f206e27..b9b9e2e01936db3786f107f405001550a16a4972 100644 (file)
@@ -1731,7 +1731,6 @@ tu_reset_cmd_buffer(struct tu_cmd_buffer *cmd_buffer)
    tu_cs_reset(cmd_buffer->device, &cmd_buffer->sub_cs);
 
    for (unsigned i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; i++) {
-      cmd_buffer->descriptors[i].dirty = 0;
       cmd_buffer->descriptors[i].valid = 0;
       cmd_buffer->descriptors[i].push_dirty = false;
    }
index 81f71ad44874b5833d666a0097eb6191248964cf..a71e0fd138c5af06160d39e931437066e39b067f 100644 (file)
@@ -778,7 +778,6 @@ tu_get_perftest_option_name(int id);
 struct tu_descriptor_state
 {
    struct tu_descriptor_set *sets[MAX_SETS];
-   uint32_t dirty;
    uint32_t valid;
    struct tu_push_descriptor_set push_set;
    bool push_dirty;