radeonsi: Lower TGSI_OPCODE_MEMBAR down to LLVM op
authorNicolai Hähnle <nicolai.haehnle@amd.com>
Thu, 10 Mar 2016 23:12:44 +0000 (18:12 -0500)
committerNicolai Hähnle <nicolai.haehnle@amd.com>
Mon, 21 Mar 2016 20:34:25 +0000 (15:34 -0500)
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
src/gallium/drivers/radeonsi/si_shader.c

index b487a3f6d13f4a5621b8cc21b818477533afc167..ca90178f07555bddd2a680b831ac14726fd64c80 100644 (file)
@@ -2713,6 +2713,35 @@ static void build_tex_intrinsic(const struct lp_build_tgsi_action *action,
                                struct lp_build_tgsi_context *bld_base,
                                struct lp_build_emit_data *emit_data);
 
+/* Prevent optimizations (at least of memory accesses) across the current
+ * point in the program by emitting empty inline assembly that is marked as
+ * having side effects.
+ */
+static void emit_optimization_barrier(struct si_shader_context *ctx)
+{
+       LLVMBuilderRef builder = ctx->radeon_bld.gallivm.builder;
+       LLVMTypeRef ftype = LLVMFunctionType(ctx->voidt, NULL, 0, false);
+       LLVMValueRef inlineasm = LLVMConstInlineAsm(ftype, "", "", true, false);
+       LLVMBuildCall(builder, inlineasm, NULL, 0, "");
+}
+
+static void membar_emit(
+               const struct lp_build_tgsi_action *action,
+               struct lp_build_tgsi_context *bld_base,
+               struct lp_build_emit_data *emit_data)
+{
+       struct si_shader_context *ctx = si_shader_context(bld_base);
+
+       /* Since memoryBarrier only makes guarantees about atomics and
+        * coherent image accesses (which bypass TC L1), we do not need to emit
+        * any special cache handling here.
+        *
+        * We do have to prevent LLVM from re-ordering loads across
+        * the barrier though.
+        */
+       emit_optimization_barrier(ctx);
+}
+
 static bool tgsi_is_array_sampler(unsigned target)
 {
        return target == TGSI_TEXTURE_1D_ARRAY ||
@@ -5315,6 +5344,8 @@ static void si_init_shader_ctx(struct si_shader_context *ctx,
        bld_base->op_actions[TGSI_OPCODE_ATOMIMAX] = tmpl;
        bld_base->op_actions[TGSI_OPCODE_ATOMIMAX].intr_name = "smax";
 
+       bld_base->op_actions[TGSI_OPCODE_MEMBAR].emit = membar_emit;
+
        bld_base->op_actions[TGSI_OPCODE_DDX].emit = si_llvm_emit_ddxy;
        bld_base->op_actions[TGSI_OPCODE_DDY].emit = si_llvm_emit_ddxy;
        bld_base->op_actions[TGSI_OPCODE_DDX_FINE].emit = si_llvm_emit_ddxy;