RISC-V: Make objdump disassembly work right for binary files.

Without the ELF header to set info->endian, it ends up as BFD_UNKNOWN_ENDIAN
which gets printed as big-endian.  But RISC-V instructions are always little
endian, so we can set endian_code correctly, and then set display_endian from
that.  This is similar to how the aarch64 support works, but without the
support for constant pools, as we don't have that on RISC-V.

	opcodes/
	PR binutils/24739
	* riscv-dis.c (riscv_disasemble_insn): Set info->endian_code.
	Set info->display_endian to info->endian_code.

diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index e669421a9645a047b67f3eb73f5f69269bd5aa2d..d467c979a9faf8e998c57bad2197e3106c91640e 100644 (file)
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,9 @@
+2019-06-26  Jim Wilson  <jimw@sifive.com>
+
+       PR binutils/24739
+       * riscv-dis.c (riscv_disasemble_insn): Set info->endian_code.
+       Set info->display_endian to info->endian_code.
+
 2019-06-25  Jan Beulich  <jbeulich@suse.com>
 
        * i386-gen.c (operand_type_init): Correct OPERAND_TYPE_DEBUG
@@ -27,7 +33,7 @@
        * i386-dis.c (prefix_table): Use Edq for cvtsi2ss and cvtsi2sd.
        Use Gdq for cvttss2si, cvttsd2si, cvtss2si, and cvtsd2si, and
        movnti.
-       * i386-opc.tbl (movnti): Add IgnoreSize. 
+       * i386-opc.tbl (movnti): Add IgnoreSize.
        * i386-tbl.h: Re-generate.
 
 2019-06-25  Jan Beulich  <jbeulich@suse.com>

diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c
index 764c4d4d256705aeed855484e791bd4eed6c0c39..40893c3dcb013eef4f067a300af136e013a4ef6f 100644 (file)
--- a/opcodes/riscv-dis.c
+++ b/opcodes/riscv-dis.c
@@ -395,9 +395,13 @@ riscv_disassemble_insn (bfd_vma memaddr, insn_t word, disassemble_info *info)
 
   insnlen = riscv_insn_length (word);
 
+  /* RISC-V instructions are always little-endian.  */
+  info->endian_code = BFD_ENDIAN_LITTLE;
+
   info->bytes_per_chunk = insnlen % 4 == 0 ? 4 : 2;
   info->bytes_per_line = 8;
-  info->display_endian = info->endian;
+  /* We don't support constant pools, so this must be code.  */
+  info->display_endian = info->endian_code;
   info->insn_info_valid = 1;
   info->branch_delay_insns = 0;
   info->data_size = 0;