re PR target/89093 (C++ exception handling clobbers d8 VFP register)

	PR target/89093
	* config/aarch64/aarch64.c (aarch64_process_one_target_attr): Don't skip
	whitespace at the start of target attribute string.

	* gcc.target/aarch64/pr89093.c: New test.
	* gcc.target/aarch64/pr63304_1.c: Remove space from target string.

From-SVN: r270690

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 471a96f4f65b213e3be9548569c45998abc88207..4ed2fc4dbfcee4676243c100fd48fef4f07b1760 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,8 +1,14 @@
+2019-04-30  Jakub Jelinek  <jakub@redhat.com>
+
+       PR target/89093
+       * config/aarch64/aarch64.c (aarch64_process_one_target_attr): Don't skip
+       whitespace at the start of target attribute string.
+
 2019-04-30  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>
 
        PR target/86538
        * config/aarch64/aarch64-c.c (aarch64_update_cpp_builtins):
-       Define __ARM_FEATURE_ATOMICS
+       Define __ARM_FEATURE_ATOMICS.
 
 2019-04-30  Martin Liska  <mliska@suse.cz>
 

diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
index 14259439c9079c9139fca51370765cce54127890..c3c88c80bbe52173f99c30184410a63e81fac61e 100644 (file)
--- a/gcc/config/aarch64/aarch64.c
+++ b/gcc/config/aarch64/aarch64.c
@@ -12536,10 +12536,6 @@ aarch64_process_one_target_attr (char *arg_str)
   char *str_to_check = (char *) alloca (len + 1);
   strcpy (str_to_check, arg_str);
 
-  /* Skip leading whitespace.  */
-  while (*str_to_check == ' ' || *str_to_check == '\t')
-    str_to_check++;
-
   /* We have something like __attribute__ ((target ("+fp+nosimd"))).
      It is easier to detect and handle it explicitly here rather than going
      through the machinery for the rest of the target attributes in this

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index b1f258583154828099b7a1be5bfcb9721e754cb1..b3908ea49c9ccebe7f3c390d72486b1590f07d14 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,5 +1,9 @@
 2019-04-30  Jakub Jelinek  <jakub@redhat.com>
 
+       PR target/89093
+       * gcc.target/aarch64/pr89093.c: New test.
+       * gcc.target/aarch64/pr63304_1.c: Remove space from target string.
+
        PR tree-optimization/89475
        * gcc.dg/tree-ssa/pr89475.c: New test.
 

diff --git a/gcc/testsuite/gcc.target/aarch64/pr63304_1.c b/gcc/testsuite/gcc.target/aarch64/pr63304_1.c
index b00f9a6862156a6c1ec272dd980cf720c317de19..99b155269aa8f5f828295007f72235d96577d0ef 100644 (file)
--- a/gcc/testsuite/gcc.target/aarch64/pr63304_1.c
+++ b/gcc/testsuite/gcc.target/aarch64/pr63304_1.c
@@ -1,7 +1,7 @@
 /* { dg-do assemble } */
 /* { dg-options "-O1 --save-temps" } */
 #pragma GCC push_options
-#pragma GCC target ("+nothing+simd, cmodel=small")
+#pragma GCC target ("+nothing+simd,cmodel=small")
 
 int
 cal (double a)

diff --git a/gcc/testsuite/gcc.target/aarch64/pr89093.c b/gcc/testsuite/gcc.target/aarch64/pr89093.c
new file mode 100644 (file)
index 0000000..08a3f41
--- /dev/null
+++ b/gcc/testsuite/gcc.target/aarch64/pr89093.c
@@ -0,0 +1,7 @@
+/* PR target/89093 */
+/* { dg-do compile } */
+
+__attribute__((target ("  no-strict-align"))) void f1 (void) {} /* { dg-error "is not valid" } */
+__attribute__((target ("       general-regs-only"))) void f2 (void) {} /* { dg-error "is not valid" } */
+#pragma GCC target ("    general-regs-only")   /* { dg-error "is not valid" } */
+void f3 (void) {}