2002-01-31 Michael Snyder <msnyder@redhat.com>

	* symfile.h (enum overlay_debugging_state):
	Define enum constant values for overlay mode.
	* symfile.c (overlay_debugging): Use enums instead of literals.
	(overlay_is_mapped, overlay_auto_command,
	overlay_manual_command): Ditto.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 9464960328b850048df5635d3262b2e786b85332..b2299fe96ebfa507e19763de1cf1542bcbba6e4c 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
 2002-01-31  Michael Snyder  <msnyder@redhat.com>
 
+       * symfile.h (enum overlay_debugging_state): 
+       Define enum constant values for overlay mode.
+       * symfile.c (overlay_debugging): Use enums instead of literals.
+       (overlay_is_mapped, overlay_auto_command, 
+       overlay_manual_command): Ditto. 
+
        * breakpoint.c (insert_breakpoints, remove_breakpoint, 
        breakpoint_here_p, breakpoint_inserted_here_p, 
        breakpoint_thread_match, bpstat_stop_status, 

diff --git a/gdb/symfile.c b/gdb/symfile.c
index e66db980c9263294cd5d58a9a099f0c42081c7ae..e77c9c25d65423a3787fabb56aefc1b9093176f7 100644 (file)
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -2509,7 +2509,7 @@ init_psymbol_list (struct objfile *objfile, int total_symbols)
 
 /* Overlay debugging state: */
 
-int overlay_debugging = 0;     /* 0 == off, 1 == manual, -1 == auto */
+enum overlay_debugging_state overlay_debugging = ovly_off;
 int overlay_cache_invalid = 0; /* True if need to refresh mapped state */
 
 /* Target vector for refreshing overlay mapped state */
@@ -2566,9 +2566,9 @@ overlay_is_mapped (struct obj_section *osect)
   switch (overlay_debugging)
     {
     default:
-    case 0:
+    case ovly_off:
       return 0;                        /* overlay debugging off */
-    case -1:                   /* overlay debugging automatic */
+    case ovly_auto:            /* overlay debugging automatic */
       /* Unles there is a target_overlay_update function, 
          there's really nothing useful to do here (can't really go auto)  */
       if (target_overlay_update)
@@ -2582,7 +2582,7 @@ overlay_is_mapped (struct obj_section *osect)
            (*target_overlay_update) (osect);
        }
       /* fall thru to manual case */
-    case 1:                    /* overlay debugging manual */
+    case ovly_on:              /* overlay debugging manual */
       return osect->ovly_mapped == 1;
     }
 }
@@ -2897,7 +2897,7 @@ the 'overlay manual' command.");
 static void
 overlay_auto_command (char *args, int from_tty)
 {
-  overlay_debugging = -1;
+  overlay_debugging = ovly_auto;
   if (info_verbose)
     printf_filtered ("Automatic overlay debugging enabled.");
 }
@@ -2909,7 +2909,7 @@ overlay_auto_command (char *args, int from_tty)
 static void
 overlay_manual_command (char *args, int from_tty)
 {
-  overlay_debugging = 1;
+  overlay_debugging = ovly_on;
   if (info_verbose)
     printf_filtered ("Overlay debugging enabled.");
 }
@@ -2921,7 +2921,7 @@ overlay_manual_command (char *args, int from_tty)
 static void
 overlay_off_command (char *args, int from_tty)
 {
-  overlay_debugging = 0;
+  overlay_debugging = ovly_off;
   if (info_verbose)
     printf_filtered ("Overlay debugging disabled.");
 }

diff --git a/gdb/symfile.h b/gdb/symfile.h
index 8af5aeaff14313dc852e68f75252e80bffaf7d09..9ab8068d11286538feafd0aa2a241c8541a8a622 100644 (file)
--- a/gdb/symfile.h
+++ b/gdb/symfile.h
@@ -253,7 +253,11 @@ extern void find_lowest_section (bfd *, asection *, PTR);
 extern bfd *symfile_bfd_open (char *);
 
 /* Utility functions for overlay sections: */
-extern int overlay_debugging;
+extern enum overlay_debugging_state {
+  ovly_off, 
+  ovly_on, 
+  ovly_auto
+} overlay_debugging;
 extern int overlay_cache_invalid;
 
 /* return the "mapped" overlay section  containing the PC */