Fix all DUPLICATE problems in testsuite/gdb.perf/
authorPedro Alves <pedro@palves.net>
Mon, 21 Jun 2021 21:20:21 +0000 (22:20 +0100)
committerPedro Alves <pedro@palves.net>
Fri, 24 Sep 2021 16:35:37 +0000 (17:35 +0100)
Currently running "make check-perf" shows:

 ...
 # of duplicate test names       6008
 ...

All those duplicate test names come from gdb.perf/skip-command.exp.
This commit fixes them, using with_test_prefix.

gdb/testsuite/
yyyy-mm-dd  Pedro Alves  <pedro@palves.net>

* gdb.perf/skip-command.exp (run_skip_bench): Wrap each for
iteration in with_test_prefix.

Change-Id: I38501cf70bc6b60306ee7228996ee7bcd858dc1b

gdb/testsuite/gdb.perf/skip-command.exp

index e396262af0657826518af0adb07a2d79e4a57e5e..d9f31a7e8f5cb603daf6eec2d848a3515b35540a 100644 (file)
@@ -101,9 +101,12 @@ proc run_skip_bench { kind text } {
     gdb_test_no_output "set variable flag = 1"
 
     for { set i 0 } { $i < 5 } { incr i } {
-       set nr_skips [expr $i * $SKIP_DIRECTIVE_COUNT]
-       install_skips $kind $text $nr_skips
-       gdb_test_python_run "SkipCommand\(\"skip-$kind-$nr_skips\", ${SKIP_STEP_COUNT}\)"
+       with_test_prefix "iter $i" {
+           set nr_skips [expr $i * $SKIP_DIRECTIVE_COUNT]
+           install_skips $kind $text $nr_skips
+           gdb_test_python_run \
+               "SkipCommand\(\"skip-$kind-$nr_skips\", ${SKIP_STEP_COUNT}\)"
+       }
     }
 
     gdb_test "set variable flag = 0"