2008-03-02 H.J. Lu <hongjiu.lu@intel.com>

	PR ld/5789
	* elflink.c (_bfd_elf_symbol_refs_local_p): Always return true
	for hidden and local symbols.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index ae142f197ff76d97df31a3cffcf25ec0d4f196b1..b534ee887df768938e71c2b0c826f705d09cc179 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2008-03-02  H.J. Lu  <hongjiu.lu@intel.com>
+
+       PR ld/5789
+       * elflink.c (_bfd_elf_symbol_refs_local_p): Always return true
+       for hidden and local symbols.
+
 2008-03-03  Alan Modra  <amodra@bigpond.net.au>
 
        * elf32-ppc.c (allocate_dynrelocs): Discard relocs on

diff --git a/bfd/elflink.c b/bfd/elflink.c
index 3a00a51f765ba2463ba99d9b365c01118c82af40..513979926b412408ed0a376674c1051843d7ecc5 100644 (file)
--- a/bfd/elflink.c
+++ b/bfd/elflink.c
@@ -2789,6 +2789,11 @@ _bfd_elf_symbol_refs_local_p (struct elf_link_hash_entry *h,
   if (h == NULL)
     return TRUE;
 
+  /* STV_HIDDEN or STV_INTERNAL ones must be local.  */
+  if (ELF_ST_VISIBILITY (h->other) == STV_HIDDEN
+      || ELF_ST_VISIBILITY (h->other) == STV_INTERNAL)
+    return TRUE;
+
   /* Common symbols that become definitions don't get the DEF_REGULAR
      flag set, so test it first, and don't bail out.  */
   if (ELF_COMMON_DEF_P (h))
@@ -2817,10 +2822,6 @@ _bfd_elf_symbol_refs_local_p (struct elf_link_hash_entry *h,
   if (ELF_ST_VISIBILITY (h->other) == STV_DEFAULT)
     return FALSE;
 
-  /* However, STV_HIDDEN or STV_INTERNAL ones must be local.  */
-  if (ELF_ST_VISIBILITY (h->other) != STV_PROTECTED)
-    return TRUE;
-
   hash_table = elf_hash_table (info);
   if (!is_elf_hash_table (hash_table))
     return TRUE;