-Wchar-subscripts cleanup

	* listing.c (listing_newline): Use unsigned char variable, so
 	calls to isascii,iscntrl are correct.
	* atof-generic.c (atof_generic): Cast arg to isdigit, et. al. with
	(unsigned char).
	* ecoff.c (ecoff_directive_ent,ecoff_stab): Ditto.
	* config/obj-elf.c (obj_elf_vtable_inherit): Ditto.
	* config/tc-mips.c (mips_ip,mips16_ip): Ditto.
	(my_getSmallExpression,get_number,s_mips_ent): Ditto.

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 88f687907df1211a504be9d06ce0b23614d93603..70b37ff247f5751d561a7d399c726ad9506799b7 100644 (file)
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,15 @@
+Mon May 24 13:36:55 1999  Doug Evans  <devans@canuck.cygnus.com>
+
+       -Wchar-subscripts cleanup
+       * listing.c (listing_newline): Use unsigned char variable, so
+       calls to isascii,iscntrl are correct.
+       * atof-generic.c (atof_generic): Cast arg to isdigit, et. al. with
+       (unsigned char).
+       * ecoff.c (ecoff_directive_ent,ecoff_stab): Ditto.
+       * config/obj-elf.c (obj_elf_vtable_inherit): Ditto.
+       * config/tc-mips.c (mips_ip,mips16_ip): Ditto.
+       (my_getSmallExpression,get_number,s_mips_ent): Ditto.
+
 1999-05-28  Torbjorn Granlund  <tege@matematik.su.se>
 
        * config/tc-m68k.c (m68k_ip): Check for disallowed index register

diff --git a/gas/atof-generic.c b/gas/atof-generic.c
index 316f665a454c8afddf40afd703cd8f243830daf9..de29f21341f8dc4925a59ba1f4e3eddd5f8bc095 100644 (file)
--- a/gas/atof-generic.c
+++ b/gas/atof-generic.c
@@ -220,7 +220,7 @@ atof_generic (address_of_string_pointer,
            && (!c || !strchr (string_of_decimal_exponent_marks, c)));
           p++)
        {
-         if (isdigit (c))
+         if (isdigit ((unsigned char) c))
            {
              /* This may be retracted below. */
              number_of_digits_after_decimal++;

diff --git a/gas/config/obj-elf.c b/gas/config/obj-elf.c
index f50c4b7257aacfa3942c10d7990274c4a38809d5..4ff8950d4b65e10ddfd1b6e13e6008cebe15c0e6 100644 (file)
--- a/gas/config/obj-elf.c
+++ b/gas/config/obj-elf.c
@@ -1037,7 +1037,7 @@ obj_elf_vtable_inherit (ignore)
 
   if (input_line_pointer[0] == '0'
       && (input_line_pointer[1] == '\0'
-         || isspace(input_line_pointer[1])))
+         || isspace ((unsigned char) input_line_pointer[1])))
     {
       psym = section_symbol (absolute_section);
       ++input_line_pointer;

diff --git a/gas/config/tc-mips.c b/gas/config/tc-mips.c
index 3d865fd9777227b5bf4ac740b18a631a6699c589..c25f0576e6d3633ff8937d7899e04863bcc0acd8 100644 (file)
--- a/gas/config/tc-mips.c
+++ b/gas/config/tc-mips.c
@@ -6956,13 +6956,13 @@ mips_ip (str, ip)
   /* If the instruction contains a '.', we first try to match an instruction
      including the '.'.  Then we try again without the '.'.  */
   insn = NULL;
-  for (s = str; *s != '\0' && !isspace(*s); ++s)
+  for (s = str; *s != '\0' && !isspace ((unsigned char) *s); ++s)
     continue;
 
   /* If we stopped on whitespace, then replace the whitespace with null for
      the call to hash_find.  Save the character we replaced just in case we
      have to re-parse the instruction.  */
-  if (isspace (*s))
+  if (isspace ((unsigned char) *s))
     {
       save_c = *s;
       *s++ = '\0';
@@ -6980,7 +6980,7 @@ mips_ip (str, ip)
        *(--s) = save_c;
 
       /* Scan up to the first '.' or whitespace.  */
-      for (s = str; *s != '\0' && *s != '.' && !isspace (*s); ++s)
+      for (s = str; *s != '\0' && *s != '.' && !isspace ((unsigned char) *s); ++s)
        continue;
 
       /* If we did not find a '.', then we can quit now.  */
@@ -7246,7 +7246,7 @@ mips_ip (str, ip)
              if (s[0] == '$')
                {
 
-                 if (isdigit (s[1]))
+                 if (isdigit ((unsigned char) s[1]))
                    {
                      ++s;
                      regno = 0;
@@ -7256,7 +7256,7 @@ mips_ip (str, ip)
                          regno += *s - '0';
                          ++s;
                        }
-                     while (isdigit (*s));
+                     while (isdigit ((unsigned char) *s));
                      if (regno > 31)
                        as_bad (_("Invalid register number (%d)"), regno);
                    }
@@ -7406,7 +7406,7 @@ mips_ip (str, ip)
            case 'V':
            case 'W':
              s_reset = s;
-             if (s[0] == '$' && s[1] == 'f' && isdigit (s[2]))
+             if (s[0] == '$' && s[1] == 'f' && isdigit ((unsigned char) s[2]))
                {
                  s += 2;
                  regno = 0;
@@ -7416,7 +7416,7 @@ mips_ip (str, ip)
                      regno += *s - '0';
                      ++s;
                    }
-                 while (isdigit (*s));
+                 while (isdigit ((unsigned char) *s));
 
                  if (regno > 31)
                    as_bad (_("Invalid float register number (%d)"), regno);
@@ -7848,7 +7848,7 @@ mips_ip (str, ip)
                  regno += *s - '0';
                  ++s;
                }
-             while (isdigit (*s));
+             while (isdigit ((unsigned char) *s));
              if (regno > 7)
                as_bad (_("invalid condition code register $fcc%d"), regno);
              if (*args == 'N')
@@ -7901,7 +7901,7 @@ mips16_ip (str, ip)
   mips16_small = false;
   mips16_ext = false;
 
-  for (s = str; islower (*s); ++s)
+  for (s = str; islower ((unsigned char) *s); ++s)
     ;
   switch (*s)
     {
@@ -8034,7 +8034,7 @@ mips16_ip (str, ip)
              if (s[0] != '$')
                break;
              s_reset = s;
-             if (isdigit (s[1]))
+             if (isdigit ((unsigned char) s[1]))
                {
                  ++s;
                  regno = 0;
@@ -8044,7 +8044,7 @@ mips16_ip (str, ip)
                      regno += *s - '0';
                      ++s;
                    }
-                 while (isdigit (*s));
+                 while (isdigit ((unsigned char) *s));
                  if (regno > 31)
                    {
                      as_bad (_("invalid register number (%d)"), regno);
@@ -8315,7 +8315,7 @@ mips16_ip (str, ip)
                        ++s;
                      }
                    reg1 = 0;
-                   while (isdigit (*s))
+                   while (isdigit ((unsigned char) *s))
                      {
                        reg1 *= 10;
                        reg1 += *s - '0';
@@ -8342,7 +8342,7 @@ mips16_ip (str, ip)
                              }
                          }
                        reg2 = 0;
-                       while (isdigit (*s))
+                       while (isdigit ((unsigned char) *s))
                          {
                            reg2 *= 10;
                            reg2 += *s - '0';
@@ -8626,9 +8626,9 @@ my_getSmallExpression (ep, str)
        ;
       if (sp - 4 >= str && sp[-1] == RP)
        {
-         if (isdigit (sp[-2]))
+         if (isdigit ((unsigned char) sp[-2]))
            {
-             for (sp -= 3; sp >= str && isdigit (*sp); sp--)
+             for (sp -= 3; sp >= str && isdigit ((unsigned char) *sp); sp--)
                ;
              if (*sp == '$' && sp > str && sp[-1] == LP)
                {
@@ -11472,14 +11472,14 @@ get_number ()
       ++input_line_pointer;
       negative = 1;
     }
-  if (!isdigit (*input_line_pointer))
+  if (!isdigit ((unsigned char) *input_line_pointer))
     as_bad (_("Expected simple number."));
   if (input_line_pointer[0] == '0')
     {
       if (input_line_pointer[1] == 'x')
        {
          input_line_pointer += 2;
-         while (isxdigit (*input_line_pointer))
+         while (isxdigit ((unsigned char) *input_line_pointer))
            {
              val <<= 4;
              val |= hex_value (*input_line_pointer++);
@@ -11489,7 +11489,7 @@ get_number ()
       else
        {
          ++input_line_pointer;
-         while (isdigit (*input_line_pointer))
+         while (isdigit ((unsigned char) *input_line_pointer))
            {
              val <<= 3;
              val |= *input_line_pointer++ - '0';
@@ -11497,14 +11497,14 @@ get_number ()
          return negative ? -val : val;
        }
     }
-  if (!isdigit (*input_line_pointer))
+  if (!isdigit ((unsigned char) *input_line_pointer))
     {
       printf (_(" *input_line_pointer == '%c' 0x%02x\n"),
              *input_line_pointer, *input_line_pointer);
       as_warn (_("Invalid number"));
       return -1;
     }
-  while (isdigit (*input_line_pointer))
+  while (isdigit ((unsigned char) *input_line_pointer))
     {
       val *= 10;
       val += *input_line_pointer++ - '0';
@@ -11630,7 +11630,8 @@ s_mips_ent (aent)
   if (*input_line_pointer == ',')
     input_line_pointer++;
   SKIP_WHITESPACE ();
-  if (isdigit (*input_line_pointer) || *input_line_pointer == '-')
+  if (isdigit ((unsigned char) *input_line_pointer)
+      || *input_line_pointer == '-')
     number = get_number ();
 
 #ifdef BFD_ASSEMBLER

diff --git a/gas/ecoff.c b/gas/ecoff.c
index c3c9375527a42054c9ef6b5d484e8b4c83cd8a26..d127f52f75e7f10cc97915e195307f06bb8fe401 100644 (file)
--- a/gas/ecoff.c
+++ b/gas/ecoff.c
@@ -3122,7 +3122,8 @@ ecoff_directive_ent (ignore)
       ++input_line_pointer;
       SKIP_WHITESPACE ();
     }
-  if (isdigit (*input_line_pointer) || *input_line_pointer == '-')
+  if (isdigit ((unsigned char) *input_line_pointer)
+      || *input_line_pointer == '-')
     (void) get_absolute_expression ();
 
   demand_empty_rest_of_line ();
@@ -3565,7 +3566,7 @@ ecoff_stab (sec, what, string, type, other, desc)
        listing_source_file (string);
 #endif
 
-      if (isdigit (*input_line_pointer)
+      if (isdigit ((unsigned char) *input_line_pointer)
          || *input_line_pointer == '-'
          || *input_line_pointer == '+')
        {

diff --git a/gas/listing.c b/gas/listing.c
index e2b173be7d68be23142b6fa0a1d726b60d4f2c62..4305cbdacab337d8f6f7db5a657292abd2eecbfa 100644 (file)
--- a/gas/listing.c
+++ b/gas/listing.c
@@ -375,7 +375,7 @@ listing_newline (ps)
              
              while (--len)
                {
-                 char c = * src ++;
+                 unsigned char c = * src ++;
 
                  /* Omit control characters in the listing.  */
                  if (isascii (c) && ! iscntrl (c))