Remove is_zlib_supported
authorH.J. Lu <hjl.tools@gmail.com>
Mon, 6 Apr 2015 19:19:13 +0000 (12:19 -0700)
committerH.J. Lu <hjl.tools@gmail.com>
Mon, 6 Apr 2015 19:19:13 +0000 (12:19 -0700)
Since zlib is always supported, there is no need for is_zlib_supported.

binutils/testsuite/

* binutils-all/compress.exp: Remove is_zlib_supported check.
* binutils-all/objdump.exp: Likewise.
* binutils-all/readelf.exp (readelf_compressed_wa_test): Likewise.
* lib/utils-lib.exp (run_dump_test): Likewise.
* lib/binutils-common.exp (is_zlib_supported): Removed.

gas/testsuite/

* lib/gas-defs.exp (run_dump_test): Remove is_zlib_supported check.

ld/testsuite/

* ld-elf/compress.exp: Remove is_zlib_supported check.
Fail if --compress-debug-sections doesn't work.
* lib/ld-lib.exp (run_dump_test): Remove is_zlib_supported check.

binutils/testsuite/ChangeLog
binutils/testsuite/binutils-all/compress.exp
binutils/testsuite/binutils-all/objdump.exp
binutils/testsuite/binutils-all/readelf.exp
binutils/testsuite/lib/binutils-common.exp
binutils/testsuite/lib/utils-lib.exp
gas/testsuite/ChangeLog
gas/testsuite/lib/gas-defs.exp
ld/testsuite/ChangeLog
ld/testsuite/ld-elf/compress.exp
ld/testsuite/lib/ld-lib.exp

index 65a22d80589dc718cef768b9cf7dae4711a4199b..ece81a6bc3dc87b24d5f74a939decd2257fdf487 100644 (file)
@@ -1,3 +1,11 @@
+2015-04-06  H.J. Lu  <hongjiu.lu@intel.com>
+
+       * binutils-all/compress.exp: Remove is_zlib_supported check.
+       * binutils-all/objdump.exp: Likewise.
+       * binutils-all/readelf.exp (readelf_compressed_wa_test): Likewise.
+       * lib/utils-lib.exp (run_dump_test): Likewise.
+       * lib/binutils-common.exp (is_zlib_supported): Removed.
+
 2015-04-06  H.J. Lu  <hongjiu.lu@intel.com>
 
        * binutils-all/compress.exp (compression_used): Remove "/dev/null"
index b4a94688e9478f12d58c6a47ff7d1152f010f75e..36b2a26d3aa2ca4b89569df6f1248dae25a67897 100644 (file)
@@ -16,7 +16,7 @@
 
 # Test compressed .debug section.
 
-if { [is_remote host] || ![is_elf_format] || ![is_zlib_supported] } then {
+if { [is_remote host] || ![is_elf_format] } then {
     return
 }
 
index 6b7d33267bcf6782d8e66c7777141d809e9d63de..6d5e76f8a23208880e1028d3bb60c33fb95bdc05 100644 (file)
@@ -158,7 +158,7 @@ if [regexp $want $got] then {
 
 # Test objdump -s on a file that contains a compressed .debug section
 
-if { ![is_elf_format] || ![is_zlib_supported] } then {
+if { ![is_elf_format] } then {
     unsupported "objdump compressed debug"
 } elseif { ![binutils_assemble $srcdir/$subdir/dw2-compressed.S tmpdir/dw2-compressed.o] } then {
     fail "objdump compressed debug"
index 1d0ea3b1d4103ec30cbf47d7aedd62961115071f..3c6472be1bafa96dcb99a0f231e7ff3f7208e33a 100644 (file)
@@ -224,11 +224,6 @@ proc readelf_compressed_wa_test {} {
     global srcdir
     global subdir
 
-    if { ![is_zlib_supported] } {
-       unsupported "readelf -wa (compressed)"
-       return
-    }
-
     # Compile the compressed-debug-section test file.
     if { [target_compile $srcdir/$subdir/dw2-compressed.S tmpdir/dw2-compressed.o object debug] != "" } {
        verbose "Unable to compile test file."
index e989da473d85eafac98e1edded57b9d6b605fd96..5dadc42a67c2efeef71a3dea6b4f714dcf14ffaa 100644 (file)
@@ -152,11 +152,6 @@ proc is_elf64 { binary_file } {
     return 0
 }
 
-# True if the build supports zlib compression.
-proc is_zlib_supported {} {
-    return 1
-}
-
 # Compare two files line-by-line.  FILE_1 is the actual output and FILE_2
 # is the expected output.  Ignore blank lines in either file.
 #
index 8dac718784b184faa14d9ae3fe5d34805a91f284..b366b639ff635160c031f7d310ed6fd84e524f0f 100644 (file)
@@ -438,12 +438,6 @@ proc run_dump_test { name {extra_options {}} } {
        }
     }
 
-    if { [string match "*--compress-debug-sections*" $opts(as)] \
-        && ![is_zlib_supported] } {
-       unsupported $testname
-       return
-    }
-
     if { $opts(source) == "" } {
        set srcfile ${file}.s
     } else {
index e26755ea1416bdd8a52d37bfeca23a39fbb850ae..c896ec52faf99844ea0d46411f5141f06c9d9a6b 100644 (file)
@@ -1,3 +1,7 @@
+2015-04-06  H.J. Lu  <hongjiu.lu@intel.com>
+
+       * lib/gas-defs.exp (run_dump_test): Remove is_zlib_supported check.
+
 2015-03-20  H.J. Lu  <hongjiu.lu@intel.com>
 
        * gas/i386/i386.exp: Don't run nops-1-bdver1, nops-1-bdver2,
index 602ad575a9ef97f94898e7a3340eb9e54b1e17e8..7dc48077e7e51344b6abd2b6988ca455a1a9af50 100644 (file)
@@ -615,13 +615,6 @@ proc run_dump_test { name {extra_options {}} } {
        }
     }
 
-    if { [string match "*--compress-debug-sections*" $opts(as)] \
-        && ![is_zlib_supported] } {
-       unsupported $testname
-       return
-    }
-
-
     if { $opts(source) == "" } {
        set sourcefile ${file}.s
     } else {
index 2b8d3453f6acda9965beab03b6c7dbec26c71f41..5036af1f03015645c404b42ffa9c420b52e6a8ac 100644 (file)
@@ -1,3 +1,9 @@
+2015-04-06  H.J. Lu  <hongjiu.lu@intel.com>
+
+       * ld-elf/compress.exp: Remove is_zlib_supported check.
+       Fail if --compress-debug-sections doesn't work.
+       * lib/ld-lib.exp (run_dump_test): Remove is_zlib_supported check.
+
 2015-04-01  Tejas Belagod  <tejas.belagod@arm.com>
 
        * ld-aarch64/aarch64-elf.exp: Add erratum843419 test.
index 850e3e8ad1f0786fc65435fc19ae7f1f8338cbb6..682811a7342954ae6b972875ce9625c78a15ac60 100644 (file)
@@ -25,10 +25,6 @@ if ![is_elf_format] {
     return
 }
 
-if ![is_zlib_supported] {
-    return
-}
-
 # The following tests require running the executable generated by ld.
 if ![isnative] {
     return
@@ -41,7 +37,7 @@ if { [which $CC] == 0 } {
 
 global as
 if { ![ld_assemble $as "--compress-debug-sections $srcdir/$subdir/empty.s" tmpdir/empty.o ] } {
-    unsupported "linker compressed debug sections"
+    fail "linker compressed debug sections"
 }
 
 set build_tests {
index 667171915659cd95d8b2eec263fb932341ce0371..9e22706243ee55dc92a5ade4ecdf88039fceab05 100644 (file)
@@ -779,12 +779,6 @@ proc run_dump_test { name {extra_options {}} } {
        set dfile $srcdir/$subdir/$opts(dump)
     }
 
-    if { [string match "*--compress-debug-sections*" $opts(as)] \
-        && ![is_zlib_supported] } {
-       unsupported $testname
-       return
-    }
-
     # Time to setup xfailures.
     foreach targ $opts(xfail) {
        setup_xfail $targ