draw: fix another decompose bug affecting constant interpolated attributes
authorRoland Scheidegger <sroland@vmware.com>
Wed, 10 Dec 2014 18:39:19 +0000 (19:39 +0100)
committerRoland Scheidegger <sroland@vmware.com>
Wed, 10 Dec 2014 21:11:16 +0000 (22:11 +0100)
Previously the first provoking vertex convention would only be used if
flatshading were enabled. No matter how I look at it that cannot be possibly
correct. Maybe the code getting used was somewhat simpler that way at a time
where there weren't constant interpolated attributes, only flatshading...
(Note that all other places including the decomposition macros already do
the same.)

Reviewed-by: Jose Fonseca <jfonseca@vmware.com>
src/gallium/auxiliary/draw/draw_pt_decompose.h

index 8637085064a3c8bb6f219f8b2c6601c744e53988..0b2522c08f0648665ea4736bfb9eee0ead57d3eb 100644 (file)
@@ -3,7 +3,6 @@
    const boolean quads_flatshade_last =      \
       draw->quads_always_flatshade_last;     \
    const boolean last_vertex_last =          \
-      !(draw->rasterizer->flatshade &&       \
-        draw->rasterizer->flatshade_first);
+      !draw->rasterizer->flatshade_first;
 
 #include "draw_decompose_tmp.h"