i965/vs: Abort on unsupported opcodes rather than failing.
authorKenneth Graunke <kenneth@whitecape.org>
Tue, 27 Nov 2012 05:56:06 +0000 (21:56 -0800)
committerKenneth Graunke <kenneth@whitecape.org>
Thu, 29 Nov 2012 02:15:57 +0000 (18:15 -0800)
Final code generation should never fail.  This is a bug, and there
should be no user-triggerable cases where this could occur.

Also, we're not going to have a fail() method after the split.

Reviewed-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>
src/mesa/drivers/dri/i965/brw_vec4_emit.cpp

index b911983c0ac7df46c54f676a91afad4e913ef228..a2a5975c6b22320fcb8d124fb72a72d5891541bb 100644 (file)
@@ -641,11 +641,12 @@ vec4_visitor::generate_vs_instruction(vec4_instruction *instruction,
 
    default:
       if (inst->opcode < (int) ARRAY_SIZE(opcode_descs)) {
-        fail("unsupported opcode in `%s' in VS\n",
-             opcode_descs[inst->opcode].name);
+         _mesa_problem(ctx, "Unsupported opcode in `%s' in VS\n",
+                       opcode_descs[inst->opcode].name);
       } else {
-        fail("Unsupported opcode %d in VS", inst->opcode);
+         _mesa_problem(ctx, "Unsupported opcode %d in VS", inst->opcode);
       }
+      abort();
    }
 }