PR libstdc++/91807
authorVille Voutilainen <ville.voutilainen@gmail.com>
Thu, 2 Jul 2020 19:16:39 +0000 (22:16 +0300)
committerVille Voutilainen <ville.voutilainen@gmail.com>
Thu, 2 Jul 2020 19:16:39 +0000 (22:16 +0300)
PR libstdc++/91807
* include/std/variant
(_Copy_assign_base::operator=(const _Copy_assign_base&):
Do the move-assignment from a temporary so that the temporary
is constructed with an explicit index.
* testsuite/20_util/variant/91807.cc: New.

libstdc++-v3/include/std/variant
libstdc++-v3/testsuite/20_util/variant/91807.cc [new file with mode: 0644]

index c9504914365caa41efb3aa96e809897b63123cd5..eb3d677920505d5470eb6ccbe5d6b764fdd97c3b 100644 (file)
@@ -611,7 +611,8 @@ namespace __variant
                      this->_M_destructive_copy(__rhs_index, __rhs_mem);
                    else
                      __variant_cast<_Types...>(*this)
-                       = variant<_Types...>(__rhs_mem);
+                       = variant<_Types...>(std::in_place_index<__rhs_index>,
+                                            __rhs_mem);
                  }
              }
            else
diff --git a/libstdc++-v3/testsuite/20_util/variant/91807.cc b/libstdc++-v3/testsuite/20_util/variant/91807.cc
new file mode 100644 (file)
index 0000000..04bb5d7
--- /dev/null
@@ -0,0 +1,35 @@
+// { dg-options "-std=gnu++17" }
+// { dg-do compile { target c++17 } }
+
+// Copyright (C) 2020 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+#include <variant>
+
+struct me_data {
+  me_data() = default;
+
+  me_data(const me_data &) {};
+  me_data(me_data &&) noexcept {};
+  me_data& operator=(const me_data &) = default;
+};
+
+int main() {
+  std::variant<me_data, me_data> v1, v2;
+
+  v2 = v1;
+}